Skip to content

Commit 528faf5

Browse files
igerberclaude
andcommitted
Fix P3: stale test docstring and Rust private naming note
- Rewrite test_global_method_alias docstring to match its actual assertion (validates method="global" produces valid ATT) - Add comment in Rust explaining that only exported #[pyfunction] names were renamed; private helpers retain *_joint* names Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent fa25f70 commit 528faf5

2 files changed

Lines changed: 5 additions & 1 deletion

File tree

rust/src/trop.rs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1082,6 +1082,10 @@ pub fn bootstrap_trop_variance<'py>(
10821082

10831083
// ============================================================================
10841084
// Global method implementation
1085+
//
1086+
// Note: Only the #[pyfunction] exports were renamed (joint → global) to match
1087+
// the Python public API. The private Rust helpers below retain their original
1088+
// `*_joint*` names to keep the Rust-only rename scope minimal.
10851089
// ============================================================================
10861090

10871091
/// Compute global weights for global method estimation.

tests/test_trop.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3275,7 +3275,7 @@ def test_global_rejects_staggered_adoption(self):
32753275
trop.fit(df, 'outcome', 'treated', 'unit', 'time')
32763276

32773277
def test_global_method_alias(self, simple_panel_data):
3278-
"""method='global' works and produces same results as deprecated 'joint'."""
3278+
"""method='global' runs and produces a valid positive ATT."""
32793279
trop_est = TROP(
32803280
method="global",
32813281
lambda_time_grid=[0.0, 1.0],

0 commit comments

Comments
 (0)