Skip to content

Commit 5d1e361

Browse files
committed
R4: drop stale line-number ref in path_sup_t_bands comment
CI AI review R3 P3: the comment referenced chaisemartin_dhaultfoeuille.py:2865-2875 but the OVERALL event_study_effects[l]['cband_conf_int'] propagation now lives at ~3329-3338 in the same file. The OVERALL site is inlined inside fit() with no stable enclosing function name, so the cleanest fix is to drop the line range entirely and reference the symbol + enclosing fit() method (stable across moves). Per feedback memory 'audit-residual-drift-classes' item 6 (Hardcoded line refs).
1 parent 34cf5a1 commit 5d1e361

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

diff_diff/chaisemartin_dhaultfoeuille_results.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -629,8 +629,9 @@ class ChaisemartinDHaultfoeuilleResults:
629629
# a positive int OR `paths_of_interest` is non-empty AND
630630
# `n_bootstrap > 0`. The joint band itself is written per-horizon as
631631
# `cband_conf_int` on `path_effects[path]["horizons"][l]` (mirrors
632-
# the OVERALL `event_study_effects[l]["cband_conf_int"]` pattern at
633-
# `chaisemartin_dhaultfoeuille.py:2865-2875`). Empty-state contract:
632+
# the OVERALL `event_study_effects[l]["cband_conf_int"]` pattern
633+
# populated alongside the bootstrap propagation in
634+
# `chaisemartin_dhaultfoeuille.py::fit`). Empty-state contract:
634635
# `None` when not requested (no bootstrap, or both `by_path` and
635636
# `paths_of_interest` are `None`); `{}` when requested but no path
636637
# passed both gates (>=2 valid horizons AND a strict majority — more

0 commit comments

Comments
 (0)