Skip to content

Commit 652bc5f

Browse files
igerberclaude
andcommitted
Fix remaining stale RM strings and update review status
Update two remaining instances of "max pre-period violation" to "max pre-period first difference" in result summary and class docstring. Downgrade METHODOLOGY_REVIEW.md status to "Complete (pending R comparison)" to accurately reflect that R benchmark validation is still outstanding. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 7085238 commit 652bc5f

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

METHODOLOGY_REVIEW.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -618,8 +618,8 @@ variables appear to the left of the `|` separator.
618618
| Module | `honest_did.py` |
619619
| Primary Reference | Rambachan & Roth (2023) |
620620
| R Reference | `HonestDiD` package |
621-
| Status | **Complete** |
622-
| Last Review | 2026-03-31 |
621+
| Status | **Complete** (pending R comparison) |
622+
| Last Review | 2026-04-01 |
623623

624624
**Verified Components:**
625625
- [x] Delta^SD: second-difference constraints [1,-2,1] with delta_0=0 boundary handling

diff_diff/honest_did.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -288,7 +288,7 @@ def summary(self) -> str:
288288

289289
if self.method == "relative_magnitude":
290290
lines.append(
291-
f"Post-treatment violations bounded at {self.M:.1f}x max pre-period violation."
291+
f"Post-treatment first differences bounded at {self.M:.1f}x max pre-period first difference."
292292
)
293293
elif self.method == "smoothness":
294294
if self.M == 0:
@@ -1976,7 +1976,7 @@ class HonestDiD:
19761976
M : float, optional
19771977
Restriction parameter. Interpretation depends on method:
19781978
- smoothness: Max second difference
1979-
- relative_magnitude: Scaling factor for max pre-period violation
1979+
- relative_magnitude: Scaling factor for max pre-period first difference
19801980
Default is 1.0 for relative_magnitude, 0.0 for smoothness.
19811981
alpha : float
19821982
Significance level for confidence intervals.

0 commit comments

Comments
 (0)