Skip to content

Commit 6ac67cf

Browse files
authored
Merge pull request #444 from igerber/fix-audit-405-r2
fix-audit-405-r2: mirror PR #405 CV notation + bacon Parameters fix into sibling surfaces
2 parents 170b284 + 5c0e42a commit 6ac67cf

13 files changed

Lines changed: 15 additions & 14 deletions

diff_diff/bacon.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -402,6 +402,7 @@ def __init__(self, weights: str = "approximate"):
402402
----------
403403
weights : str, default="approximate"
404404
Weight calculation method:
405+
405406
- "approximate": Fast simplified formula (default)
406407
- "exact": Variance-based weights from Goodman-Bacon (2021)
407408
"""

diff_diff/chaisemartin_dhaultfoeuille_results.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -893,7 +893,7 @@ def summary(self, alpha: Optional[float] = None) -> str:
893893

894894
cv = self.coef_var
895895
if np.isfinite(cv):
896-
cv_label = f"CV (SE/|{overall_row_label}|):"
896+
cv_label = f"CV (SE/abs({overall_row_label})):"
897897
lines.append(f"{cv_label:<25} {cv:>10.4f}")
898898

899899
lines.append("")

diff_diff/continuous_did_results.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -276,7 +276,7 @@ def summary(self, alpha: Optional[float] = None) -> str:
276276

277277
cv = self.coef_var
278278
if np.isfinite(cv):
279-
lines.append(f"{'CV (SE/|ATT|):':<25} {cv:>10.4f}")
279+
lines.append(f"{'CV (SE/abs(ATT)):':<25} {cv:>10.4f}")
280280

281281
lines.append("")
282282

diff_diff/efficient_did_results.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,7 @@ def summary(self, alpha: Optional[float] = None) -> str:
260260

261261
cv = self.coef_var
262262
if np.isfinite(cv):
263-
lines.append(f"{'CV (SE/|ATT|):':<25} {cv:>10.4f}")
263+
lines.append(f"{'CV (SE/abs(ATT)):':<25} {cv:>10.4f}")
264264

265265
lines.append("")
266266

diff_diff/imputation_results.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,7 @@ def summary(self, alpha: Optional[float] = None) -> str:
255255

256256
cv = self.coef_var
257257
if np.isfinite(cv):
258-
lines.append(f"{'CV (SE/|ATT|):':<25} {cv:>10.4f}")
258+
lines.append(f"{'CV (SE/abs(ATT)):':<25} {cv:>10.4f}")
259259

260260
lines.append("")
261261

diff_diff/results.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -249,7 +249,7 @@ def summary(self, alpha: Optional[float] = None) -> str:
249249

250250
cv = self.coef_var
251251
if np.isfinite(cv):
252-
lines.append(f"{'CV (SE/|ATT|):':<25} {cv:>10.4f}")
252+
lines.append(f"{'CV (SE/abs(ATT)):':<25} {cv:>10.4f}")
253253

254254
# Add significance codes
255255
lines.extend(
@@ -656,7 +656,7 @@ def summary(self, alpha: Optional[float] = None) -> str:
656656

657657
cv = self.coef_var
658658
if np.isfinite(cv):
659-
lines.append(f"{'CV (SE/|ATT|):':<25} {cv:>10.4f}")
659+
lines.append(f"{'CV (SE/abs(ATT)):':<25} {cv:>10.4f}")
660660

661661
# Add significance codes
662662
lines.extend(
@@ -1052,7 +1052,7 @@ def summary(self, alpha: Optional[float] = None) -> str:
10521052

10531053
cv = self.coef_var
10541054
if np.isfinite(cv):
1055-
lines.append(f"{'CV (SE/|ATT|):':<25} {cv:>10.4f}")
1055+
lines.append(f"{'CV (SE/abs(ATT)):':<25} {cv:>10.4f}")
10561056

10571057
# Show top unit weights
10581058
if self.unit_weights:

diff_diff/stacked_did_results.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@ def summary(self, alpha: Optional[float] = None) -> str:
212212

213213
cv = self.coef_var
214214
if np.isfinite(cv):
215-
lines.append(f"{'CV (SE/|ATT|):':<25} {cv:>10.4f}")
215+
lines.append(f"{'CV (SE/abs(ATT)):':<25} {cv:>10.4f}")
216216

217217
lines.append("")
218218

diff_diff/staggered_results.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,7 @@ def summary(self, alpha: Optional[float] = None) -> str:
234234

235235
cv = self.coef_var
236236
if np.isfinite(cv):
237-
lines.append(f"{'CV (SE/|ATT|):':<25} {cv:>10.4f}")
237+
lines.append(f"{'CV (SE/abs(ATT)):':<25} {cv:>10.4f}")
238238

239239
lines.append("")
240240

diff_diff/staggered_triple_diff_results.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@ def summary(self, alpha: Optional[float] = None) -> str:
196196

197197
cv = self.coef_var
198198
if np.isfinite(cv):
199-
lines.append(f"{'CV (SE/|ATT|):':<25} {cv:>10.4f}")
199+
lines.append(f"{'CV (SE/abs(ATT)):':<25} {cv:>10.4f}")
200200

201201
lines.append("")
202202

diff_diff/sun_abraham.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ def summary(self, alpha: Optional[float] = None) -> str:
190190

191191
cv = self.coef_var
192192
if np.isfinite(cv):
193-
lines.append(f"{'CV (SE/|ATT|):':<25} {cv:>10.4f}")
193+
lines.append(f"{'CV (SE/abs(ATT)):':<25} {cv:>10.4f}")
194194

195195
lines.append("")
196196

0 commit comments

Comments
 (0)