Commit 7eeb42a
Align Phase 1c parity-contract narrative across wrapper, JSON, tests
P3 follow-up from AI review. Three small inconsistencies to resolve:
1. `bias_corrected_local_linear` docstring still described tau_cl/se_cl
as bit-parity and said Python consumes R's z directly. The actual
contract is atol=1e-12 on all four scalars (DGP 1-3) and the
wrapper computes its own z via scipy.stats.norm.ppf; R's qnorm is
stored in the JSON for audit only. Docstring updated to match.
2. Committed golden JSON metadata still had the old "consume R's
critical value directly" string because the generator was edited
without regenerating. Regenerated so JSON metadata matches the
corrected audit-export wording in the R script.
3. Parity tests for DGP 4 and DGP 5 did not assert CI bounds. Added
ci_low / ci_high assertions at the same tolerance as the
corresponding se_rb assertion (bit-parity for DGP 4, 1e-12 for
DGP 5), so the audit surface matches what the registry states.
Behavior unchanged; tests strengthened and docs aligned.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent 12a8efe commit 7eeb42a
3 files changed
Lines changed: 25 additions & 7 deletions
File tree
- benchmarks/data
- diff_diff
- tests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
| 13 | + | |
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1020 | 1020 | | |
1021 | 1021 | | |
1022 | 1022 | | |
1023 | | - | |
1024 | | - | |
1025 | | - | |
1026 | | - | |
1027 | | - | |
1028 | | - | |
| 1023 | + | |
| 1024 | + | |
| 1025 | + | |
| 1026 | + | |
| 1027 | + | |
| 1028 | + | |
| 1029 | + | |
| 1030 | + | |
| 1031 | + | |
| 1032 | + | |
| 1033 | + | |
1029 | 1034 | | |
1030 | 1035 | | |
1031 | 1036 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
192 | 192 | | |
193 | 193 | | |
194 | 194 | | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
195 | 202 | | |
196 | 203 | | |
197 | 204 | | |
| |||
210 | 217 | | |
211 | 218 | | |
212 | 219 | | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
213 | 226 | | |
214 | 227 | | |
215 | 228 | | |
| |||
0 commit comments