Commit 84d7572
Final P3 cleanup: remove unreachable TWFE conley auto-cluster + fix resolve_vcov_type docstring
Address two P3 documentation/maintenance findings from CI Codex review of
PR #411 R-final:
- twfe.py:234-240: an `elif self.vcov_type == "conley"` branch in the
cluster-resolution chain disabled the auto-cluster default for Conley.
Unreachable behind the unconditional Conley reject at twfe.py:146-163.
Removed.
- linalg.py::resolve_vcov_type docstring: the "Rules" section and
Returns docstring listed only `{"classical", "hc1", "hc2", "hc2_bm"}`,
omitting `"conley"` even though `_VALID_VCOV_TYPES` includes it and
the runtime path already accepts it. Updated both surfaces; the source
of truth pointer (`_VALID_VCOV_TYPES`) is now named explicitly so
future enum additions don't need a docstring sweep.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent af246a1 commit 84d7572
2 files changed
Lines changed: 4 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1112 | 1112 | | |
1113 | 1113 | | |
1114 | 1114 | | |
1115 | | - | |
1116 | | - | |
| 1115 | + | |
| 1116 | + | |
| 1117 | + | |
1117 | 1118 | | |
1118 | 1119 | | |
1119 | 1120 | | |
| |||
1127 | 1128 | | |
1128 | 1129 | | |
1129 | 1130 | | |
1130 | | - | |
| 1131 | + | |
1131 | 1132 | | |
1132 | 1133 | | |
1133 | 1134 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
231 | 231 | | |
232 | 232 | | |
233 | 233 | | |
234 | | - | |
235 | | - | |
236 | | - | |
237 | | - | |
238 | | - | |
239 | | - | |
240 | | - | |
241 | 234 | | |
242 | 235 | | |
243 | 236 | | |
| |||
0 commit comments