Commit 90f5261
Address PR #391 R2 review (1 P3): tighten snapshot test to assert_array_equal
Reviewer noted the snapshot test docstring claims "byte-for-byte / bit
identity" but the assertion was assert_allclose(atol=1e-14, rtol=1e-14),
which is slightly weaker than the wording suggests.
Switch to np.testing.assert_array_equal so the assertion strength
matches the stated contract. Snapshot values are either exact f64
(Rademacher = +/-1.0) or computed once via correctly-rounded IEEE 754
sqrt in Rust (Mammen's golden-ratio constants, Webb's sqrt(N/2)
constants), so cross-platform bit-equality holds on conformant
hardware. Inline comment added explaining the safety argument.
If a runner ever fails this test on a hardware/sqrt drift basis (very
unlikely on x86_64 / aarch64 / ARM64 Windows), we'd learn something
useful about that runner before deciding to soften the check.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent 06b3b17 commit 90f5261
1 file changed
Lines changed: 5 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
141 | 141 | | |
142 | 142 | | |
143 | 143 | | |
144 | | - | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
145 | 149 | | |
146 | 150 | | |
147 | | - | |
148 | | - | |
149 | 151 | | |
150 | 152 | | |
151 | 153 | | |
| |||
0 commit comments