Commit 916efc6
Address PR #372 R9 review (1 P3): HAD WAS vs WAS_{d̲} estimand distinction
P3 - HAD summary copy compressed both Design 1' and Design 1 into "targets
WAS", but the shipped class contract distinguishes them:
- Design 1' (`d̲ = 0`, `continuous_at_zero` path): identifies the original
Weighted Average Slope (WAS, paper Equation 2). `target_parameter == "WAS"`
on the result class.
- Design 1 (`d̲ > 0`, `continuous_near_d_lower` or `mass_point` paths):
identifies `WAS_{d̲}` under Assumption 6 (or sign identification only
under Assumption 5; both are non-testable via pre-trends).
`target_parameter == "WAS_d_lower"` on the result class.
Rewrite the HAD summaries in three places (docs/api/had.rst, README.md
catalog one-liner, diff_diff/guides/llms.txt one-liner) to surface the
distinction explicitly. The api/had.rst summary also flags that callers
can key on the resolved `target_parameter` attribute, and that Design 1
identification requires the additional non-testable assumption beyond
parallel trends.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent c834cab commit 916efc6
3 files changed
Lines changed: 14 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
110 | 110 | | |
111 | 111 | | |
112 | 112 | | |
113 | | - | |
| 113 | + | |
114 | 114 | | |
115 | 115 | | |
116 | 116 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
61 | 61 | | |
62 | 62 | | |
63 | 63 | | |
64 | | - | |
| 64 | + | |
65 | 65 | | |
66 | 66 | | |
67 | 67 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | | - | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
18 | 25 | | |
19 | 26 | | |
20 | 27 | | |
| |||
0 commit comments