Skip to content

Commit 9b622cd

Browse files
authored
Merge pull request #47 from igerber/claude/review-pr-46-YRDFo
2 parents 334aeda + f5b8320 commit 9b622cd

1 file changed

Lines changed: 7 additions & 7 deletions

File tree

TODO.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -61,12 +61,12 @@ Different estimators compute SEs differently. Consider unified interface.
6161

6262
Edge cases needing tests:
6363

64-
- [ ] Very few clusters (< 5) with wild bootstrap
65-
- [ ] Unbalanced panels with missing periods
66-
- [ ] Single treated unit scenarios
67-
- [ ] Perfect collinearity detection
68-
- [ ] CallawaySantAnna with single cohort
69-
- [ ] SyntheticDiD with insufficient pre-periods
64+
- [x] Very few clusters (< 5) with wild bootstrap (added in v1.2.1)
65+
- [x] Unbalanced panels with missing periods (added in v1.2.1)
66+
- [x] Single treated unit scenarios (added in v1.2.1)
67+
- [x] Perfect collinearity detection (added in v1.2.1)
68+
- [x] CallawaySantAnna with single cohort (added in v1.2.1)
69+
- [x] SyntheticDiD with insufficient pre-periods (added in v1.2.1)
7070

7171
**Note**: 21 visualization tests are skipped when matplotlib unavailable—this is expected.
7272

@@ -97,7 +97,7 @@ Enhancements for `honest_did.py`:
9797

9898
From code review (PR #32):
9999

100-
- [ ] Refactor `_run_multiplier_bootstrap` into smaller helper methods
100+
- [x] Refactor `_run_multiplier_bootstrap` into smaller helper methods (extracted `_compute_effect_bootstrap_stats()` in v1.2.1)
101101
- [ ] Consider aligning p-value computation with R `did` package (symmetric percentile method)
102102

103103
---

0 commit comments

Comments
 (0)