Commit 9d5f8f9
Address PR #356 CI review round 15 (1 P1 guide)
§4.10 repeated-cross-section wording tightened. The earlier text
("most estimators remain applicable") overstated the RCS support
surface: only CallawaySantAnna(panel=False), TripleDifference, and
StaggeredTripleDifference have documented RCS-capable contracts
(REGISTRY.md §CallawaySantAnna; docs/choosing_estimator.rst DDD
cross-sectional use cases). EfficientDiD and HeterogeneousAdoptionDiD
explicitly reject RCS per REGISTRY.md. SyntheticDiD and ContinuousDiD
are panel-only by construction. Under the old wording an autonomous
agent could silently route RCS data to a panel-only estimator.
Rewrote §4.10 into three explicit blocks:
- "Explicit RCS support": the three RCS-capable estimators.
- "Explicitly rejected for RCS (panel-only)": names EfficientDiD,
HeterogeneousAdoptionDiD, SyntheticDiD, ContinuousDiD.
- "Treat other estimators in this guide as panel-only unless their
own docs explicitly say otherwise."
Kept the clustered-SE note and added a cluster-vs-respondent
treatment-assignment check.
Regression test: asserts the guide does not contain the "most
estimators remain applicable" phrase, names `panel=False` as the
explicit CS RCS mode, and that the §4.10 section explicitly lists
both EfficientDiD and HeterogeneousAdoptionDiD as panel-only
rejected.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent 889b24a commit 9d5f8f9
2 files changed
Lines changed: 57 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
500 | 500 | | |
501 | 501 | | |
502 | 502 | | |
503 | | - | |
504 | | - | |
505 | | - | |
506 | | - | |
507 | | - | |
508 | | - | |
509 | | - | |
| 503 | + | |
| 504 | + | |
| 505 | + | |
| 506 | + | |
| 507 | + | |
| 508 | + | |
| 509 | + | |
| 510 | + | |
| 511 | + | |
| 512 | + | |
| 513 | + | |
| 514 | + | |
| 515 | + | |
| 516 | + | |
| 517 | + | |
| 518 | + | |
| 519 | + | |
| 520 | + | |
| 521 | + | |
| 522 | + | |
| 523 | + | |
| 524 | + | |
| 525 | + | |
| 526 | + | |
| 527 | + | |
| 528 | + | |
| 529 | + | |
| 530 | + | |
| 531 | + | |
| 532 | + | |
| 533 | + | |
| 534 | + | |
| 535 | + | |
510 | 536 | | |
511 | 537 | | |
512 | 538 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
745 | 745 | | |
746 | 746 | | |
747 | 747 | | |
| 748 | + | |
| 749 | + | |
| 750 | + | |
| 751 | + | |
| 752 | + | |
| 753 | + | |
| 754 | + | |
| 755 | + | |
| 756 | + | |
| 757 | + | |
| 758 | + | |
| 759 | + | |
| 760 | + | |
| 761 | + | |
| 762 | + | |
| 763 | + | |
| 764 | + | |
| 765 | + | |
| 766 | + | |
| 767 | + | |
| 768 | + | |
| 769 | + | |
| 770 | + | |
| 771 | + | |
748 | 772 | | |
749 | 773 | | |
750 | 774 | | |
| |||
0 commit comments