Commit a202dca
committed
PR #457 R11 polish: harmonize R script header + meta.description template
R11 verdict was Looks good with 1 P3 informational item: I had updated
the committed JSON's meta.description in R10 to describe the narrowed
contract, but the R generator script at benchmarks/R/generate_bacon_golden.R
still had the old "atol=1e-6 on per-component (treated, control, type)
tuples plus TWFE coefficient" description in BOTH (a) its header
docstring (lines 8-22) AND (b) its meta.description value template
(lines 218-225). Re-running the script would have overwritten my
committed JSON polish with the old contradictory description.
Updated both surfaces to the three-tier contract: (1) aggregate
TWFE + weights-sum on all 3 fixtures; (2) direct per-component parity
on the 2 non-remap fixtures + 6 timing-vs-timing rows of
always_treated_remapped; (3) cohort fold-back parity for the U
bucket on always_treated_remapped. Pointers to REGISTRY Note (R
parity convention divergence on always-treated) + Deviation (first-
period boundary extension).
Re-ran the R script; JSON written matches the committed text and tests
remain green (4/4 in TestBaconParityR, 34/34 across the file). Script
is now idempotent on its own committed output.1 parent a86498e commit a202dca
1 file changed
Lines changed: 29 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
11 | | - | |
12 | | - | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
13 | 25 | | |
14 | 26 | | |
15 | 27 | | |
| |||
18 | 30 | | |
19 | 31 | | |
20 | 32 | | |
21 | | - | |
22 | | - | |
| 33 | + | |
| 34 | + | |
23 | 35 | | |
24 | 36 | | |
25 | 37 | | |
| |||
220 | 232 | | |
221 | 233 | | |
222 | 234 | | |
223 | | - | |
224 | | - | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
225 | 247 | | |
226 | 248 | | |
227 | 249 | | |
| |||
0 commit comments