Skip to content

Commit aabb404

Browse files
igerberclaude
andcommitted
Propagate replicate design params through subpopulation, subset_to_units, CS collapse
Carry combined_weights, replicate_scale, replicate_rscales, and mse through all three helper constructors that build derivative ResolvedSurveyDesign or SurveyDesign objects: - SurveyDesign.subpopulation() → new SurveyDesign - ResolvedSurveyDesign.subset_to_units() → new ResolvedSurveyDesign - CallawaySantAnna._collapse_survey_to_unit_level() → new ResolvedSurveyDesign Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 088bdc2 commit aabb404

2 files changed

Lines changed: 12 additions & 0 deletions

File tree

diff_diff/staggered.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -407,6 +407,10 @@ def _collapse_survey_to_unit_level(resolved_survey, df, unit_col, all_units):
407407
fay_rho=resolved_survey.fay_rho,
408408
n_replicates=resolved_survey.n_replicates,
409409
replicate_strata=resolved_survey.replicate_strata,
410+
combined_weights=resolved_survey.combined_weights,
411+
replicate_scale=resolved_survey.replicate_scale,
412+
replicate_rscales=resolved_survey.replicate_rscales,
413+
mse=resolved_survey.mse,
410414
)
411415

412416
def _precompute_structures(

diff_diff/survey.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -520,6 +520,10 @@ def subpopulation(
520520
replicate_method=self.replicate_method,
521521
fay_rho=self.fay_rho,
522522
replicate_strata=self.replicate_strata,
523+
combined_weights=self.combined_weights,
524+
replicate_scale=self.replicate_scale,
525+
replicate_rscales=self.replicate_rscales,
526+
mse=self.mse,
523527
)
524528

525529
return new_design, data_out
@@ -611,6 +615,10 @@ def subset_to_units(
611615
fay_rho=self.fay_rho,
612616
n_replicates=self.n_replicates,
613617
replicate_strata=self.replicate_strata,
618+
combined_weights=self.combined_weights,
619+
replicate_scale=self.replicate_scale,
620+
replicate_rscales=self.replicate_rscales,
621+
mse=self.mse,
614622
)
615623

616624
@property

0 commit comments

Comments
 (0)