Skip to content

Commit aace57b

Browse files
igerberclaude
andcommitted
Fix remaining review nits (P2/P3)
- Align roadmap: "superpopulation quantity" → "finite-population quantity" - Fix double negative in didimputation/eventstudyinteract sentence - Clarify N_hat: after normalization sum(w_i) = n; scaling is variance-equivalent because only relative weights affect sandwich meat Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 3a5d1d9 commit aace57b

2 files changed

Lines changed: 5 additions & 4 deletions

File tree

docs/methodology/survey-theory.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ does not account for stratification or finite population corrections. Stata's
100100
estimation and supports clustered wild bootstrap, but does not support the
101101
`svy:` prefix --- there is no mechanism for strata or FPC.
102102
`did_multiplegt_dyn` (de Chaisemartin & D'Haultfoeuille) clusters at the group
103-
level by default but likewise lacks strata and FPC support. Neither
103+
level by default but likewise lacks strata and FPC support.
104104
`eventstudyinteract` (Sun & Abraham) does not accept probability weights.
105105
`didimputation` (Borusyak, Jaravel & Spiess) accepts estimation weights via
106106
`wname` but does not provide survey-design variance.
@@ -380,8 +380,9 @@ T(F_hat_w) - T(F) = sum_i d_i * psi_i + o_p(n^{-1/2})
380380

381381
where d_i = 1 if unit i is sampled (0 otherwise), and psi_i = w_i * IF(x_i;
382382
T, F) / N is the scaled influence function value. (In practice, the population
383-
size N is typically unknown and is estimated by N_hat = sum_i w_i, the sum of
384-
sampling weights; the implementation uses N_hat.) The key observation: this
383+
size N is typically unknown and is estimated by N_hat = sum_i w_i. After
384+
diff-diff normalizes pweights to mean 1, sum_i w_i = n; the scaling is
385+
variance-equivalent because only relative weights affect the sandwich meat.) The key observation: this
385386
linearized form is a weighted sum over the sampled observations, and its
386387
variance is determined by the sampling design --- not by T. The IF transforms
387388
the problem of estimating Var(theta_hat) into the simpler problem of estimating

docs/survey-roadmap.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ design-based variance estimation with modern DiD influence functions:
120120
1. Modern heterogeneity-robust DiD estimators (CS, SA, BJS) are smooth
121121
functionals of the weighted empirical distribution
122122
2. Survey-weighted empirical distribution is design-consistent for the
123-
superpopulation quantity (Hájek/design-weighted estimator)
123+
finite-population quantity (Hájek/design-weighted estimator)
124124
3. The influence function is a property of the functional, not the
125125
sampling design — IFs remain valid under survey weighting
126126
4. TSL (stratified cluster sandwich) and replicate-weight methods are

0 commit comments

Comments
 (0)