Skip to content

Commit b731c33

Browse files
igerberclaude
andcommitted
Address P3 review feedback on notebook workflow
- Reword schedule comment: "smoke test" instead of overstating dataset URL breakage detection (loaders have fallbacks) - Add "Keep in sync" comment on manual dep list, matching the convention in rust-test.yml python-fallback job - Note why pip install -e . isn't used (requires Rust toolchain) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 07fe1fb commit b731c33

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

.github/workflows/notebooks.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ on:
1616
- 'pyproject.toml'
1717
- '.github/workflows/notebooks.yml'
1818
schedule:
19-
# Weekly Sunday 6am UTC — catches external breakage (dataset URLs, etc.)
19+
# Weekly Sunday 6am UTC — smoke test that notebooks still execute cleanly
2020
- cron: '0 6 * * 0'
2121

2222
jobs:
@@ -33,9 +33,11 @@ jobs:
3333
python-version: '3.11'
3434

3535
- name: Install dependencies
36+
# Keep in sync with pyproject.toml [project.dependencies] and [project.optional-dependencies.dev]
3637
run: |
3738
pip install numpy pandas scipy matplotlib nbmake pytest ipykernel
3839
# Add repo root to Python path so Jupyter kernels can import diff_diff
40+
# (pip install -e . requires the Rust/maturin toolchain; .pth avoids that)
3941
python -c "import site; print(site.getsitepackages()[0])" | xargs -I{} sh -c 'echo "$PWD" > {}/diff_diff_dev.pth'
4042
4143
- name: Execute notebooks

0 commit comments

Comments
 (0)