Skip to content

Commit bbbcc4d

Browse files
igerberclaude
andcommitted
Address PR #348 CI review P3: drop stale TODO row-87 reference in test docstring
After this PR deletes the old row 87 from TODO.md, row 87 now points to a different item. Replace the row-number breadcrumb with "Silent-failures audit Finding #23 (grid-search half)" which is stable across future TODO.md reshuffles. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent e59610b commit bbbcc4d

1 file changed

Lines changed: 7 additions & 6 deletions

File tree

tests/test_rust_backend.py

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2207,12 +2207,13 @@ def _make_correlated_panel(n_units=6, n_periods=5, n_treated=2):
22072207
def test_grid_search_rank_deficient_Y(self):
22082208
"""Grid-search ATT parity on rank-deficient Y.
22092209
2210-
Finding #23 / TODO row 87 regression guard. Previously a ~6%
2211-
ATT divergence on two near-parallel control units because the
2212-
Rust inner solver used iterative block coordinate descent while
2213-
the Python fallback used SVD-based minimum-norm least squares.
2214-
Fixed by porting the Rust inner solver to an SVD-based WLS path
2215-
(numpy-compatible rcond = eps*max(n,k)) that mirrors Python's
2210+
Silent-failures audit Finding #23 (grid-search half) regression
2211+
guard. Previously a ~6% ATT divergence on two near-parallel
2212+
control units because the Rust inner solver used iterative block
2213+
coordinate descent while the Python fallback used SVD-based
2214+
minimum-norm least squares. Fixed by porting the Rust inner
2215+
solver to an SVD-based WLS path (numpy-compatible
2216+
rcond = eps*max(n,k)) that mirrors Python's
22162217
`np.linalg.lstsq(rcond=None)` step-for-step. This test asserts
22172218
the backends now agree at atol=1e-6 on rank-deficient Y.
22182219
"""

0 commit comments

Comments
 (0)