Skip to content

Commit c865816

Browse files
igerberclaude
andcommitted
Remove invalid placebo from MultiPeriodDiD handler
run_all_placebo_tests() requires binary time indicator, which MultiPeriodDiD does not use (it has multi-period time). Removed the placebo step from _handle_multi_period; HonestDiD (which IS supported for MultiPeriodDiDResults) remains as the sensitivity tool. DiD handler already correctly uses _placebo_step() (valid for 2x2 with binary time) and does not suggest HonestDiD (not supported for DiDResults). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 8ce4441 commit c865816

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

diff_diff/practitioner.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -281,7 +281,7 @@ def _covariates_step() -> Dict[str, Any]:
281281
def _handle_did(results: Any):
282282
steps = [
283283
_parallel_trends_step(),
284-
_placebo_step(),
284+
_placebo_step(), # valid: basic 2x2 DiD with binary time
285285
_step(
286286
baker_step=4,
287287
label="Check if data is actually staggered",
@@ -306,7 +306,8 @@ def _handle_multi_period(results: Any):
306306
steps = [
307307
_parallel_trends_step(),
308308
_honest_did_step(),
309-
_placebo_step(),
309+
# Note: run_all_placebo_tests() requires binary time indicator,
310+
# which MultiPeriodDiD does not use. Omit placebo for this type.
310311
_robustness_compare_step("CS, SA, or BJS"),
311312
]
312313
warnings = _check_nan_att(results)

0 commit comments

Comments
 (0)