Commit d20988d
dCDH heterogeneity: align fit() docstring + summary note with new contract
Two stale in-code documentation surfaces from the latest review:
1. `chaisemartin_dhaultfoeuille.py:980-989` — the `heterogeneity`
parameter docstring on `fit()` still said "post-treatment regressions
only (no placebo regressions)". Updated to document the post-#422
contract: per-horizon OLS regressions on forward AND backward
(placebo) horizons when `placebo=True`; survey_design composes with
forward horizons but warns + skips backward horizons until the
pre-period cell allocator is derived.
2. `chaisemartin_dhaultfoeuille_results.py:1279-1286` — the heterogeneity
summary note didn't mention the survey forward-only fallback.
Extended the note to cover the gating semantics so users reading
`result.summary()` under `survey_design + heterogeneity` know what
they're getting.
Both surfaces now match the contract already documented in the API rst,
REGISTRY, and CHANGELOG. No behavior change.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent bcdb00a commit d20988d
2 files changed
Lines changed: 23 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
980 | 980 | | |
981 | 981 | | |
982 | 982 | | |
983 | | - | |
984 | | - | |
985 | | - | |
986 | | - | |
987 | | - | |
988 | | - | |
989 | | - | |
990 | | - | |
| 983 | + | |
| 984 | + | |
| 985 | + | |
| 986 | + | |
| 987 | + | |
| 988 | + | |
| 989 | + | |
| 990 | + | |
| 991 | + | |
| 992 | + | |
| 993 | + | |
| 994 | + | |
| 995 | + | |
| 996 | + | |
| 997 | + | |
| 998 | + | |
| 999 | + | |
| 1000 | + | |
| 1001 | + | |
991 | 1002 | | |
992 | 1003 | | |
993 | 1004 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1280 | 1280 | | |
1281 | 1281 | | |
1282 | 1282 | | |
1283 | | - | |
| 1283 | + | |
| 1284 | + | |
| 1285 | + | |
| 1286 | + | |
1284 | 1287 | | |
1285 | 1288 | | |
1286 | 1289 | | |
| |||
0 commit comments