Commit dc2045f
Address PR #351 R9 P3: unify SDID bootstrap slowdown wording
Single actionable P3 from R9 CI review: user-facing runtime wording for
refit bootstrap had diverged across surfaces, giving conflicting
expectations about the cost of the new bootstrap path:
- CHANGELOG.md and diff_diff/synthetic_did.py said ~5-30x slower.
- diff_diff/power.py said ~10-100x slower (two sites).
- docs/choosing_estimator.rst said ~10-100x slower.
- docs/performance-scenarios.md said ~10-100x slower.
- docs/methodology/REGISTRY.md coverage-MC block said ~10-100x slower.
- docs/tutorials/03_synthetic_did.ipynb and
docs/tutorials/18_geo_experiments.ipynb said ~10-100x slower.
- benchmarks/python/coverage_sdid.py said the 500-seed MC run takes
~2-4 hours, while REGISTRY.md said ~15-40 min (the actually-observed
wall-clock; aer63 is ~37 min, balanced + unbalanced ~2 min combined).
Unify on "~5-30x slower than placebo (panel-size dependent)" for the
per-fit slowdown (the warm-start plumbing closed the gap vs the pre-
warm-start cold-start estimate of 10-100x) and on "~15-40 min" for the
coverage MC wall-clock. The CHANGELOG entry already notes the 10-100x
figure as a historical "prior estimate" — left as-is so the release
notes continue to explain the revision.
Also fix two tutorial surfaces that still called placebo "R's default"
(tutorial 03, sections 7 and 10). R's default is bootstrap; placebo is
the library default per the REGISTRY Note added in 710f966. Reword to
describe placebo as the library default with the rationale pointer.
Verified: 353 tests pass across test_methodology_sdid, test_power,
test_guides (UTF-8 fingerprint preserved). Tutorial-18 nbmake drift
guards unaffected because the change is markdown-only.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent 710f966 commit dc2045f
7 files changed
Lines changed: 14 additions & 21 deletions
File tree
- benchmarks/python
- diff_diff
- docs
- methodology
- tutorials
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
15 | 17 | | |
16 | 18 | | |
17 | 19 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
718 | 718 | | |
719 | 719 | | |
720 | 720 | | |
721 | | - | |
| 721 | + | |
722 | 722 | | |
723 | 723 | | |
724 | 724 | | |
| |||
2047 | 2047 | | |
2048 | 2048 | | |
2049 | 2049 | | |
2050 | | - | |
| 2050 | + | |
2051 | 2051 | | |
2052 | 2052 | | |
2053 | 2053 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
611 | 611 | | |
612 | 612 | | |
613 | 613 | | |
614 | | - | |
| 614 | + | |
615 | 615 | | |
616 | 616 | | |
617 | 617 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1505 | 1505 | | |
1506 | 1506 | | |
1507 | 1507 | | |
1508 | | - | |
| 1508 | + | |
1509 | 1509 | | |
1510 | 1510 | | |
1511 | 1511 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
235 | 235 | | |
236 | 236 | | |
237 | 237 | | |
238 | | - | |
239 | | - | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
240 | 241 | | |
241 | 242 | | |
242 | 243 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
398 | 398 | | |
399 | 399 | | |
400 | 400 | | |
401 | | - | |
| 401 | + | |
402 | 402 | | |
403 | 403 | | |
404 | 404 | | |
| |||
599 | 599 | | |
600 | 600 | | |
601 | 601 | | |
602 | | - | |
| 602 | + | |
603 | 603 | | |
604 | 604 | | |
605 | 605 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
854 | 854 | | |
855 | 855 | | |
856 | 856 | | |
857 | | - | |
858 | | - | |
859 | | - | |
860 | | - | |
861 | | - | |
862 | | - | |
863 | | - | |
864 | | - | |
865 | | - | |
866 | | - | |
867 | | - | |
| 857 | + | |
868 | 858 | | |
869 | 859 | | |
870 | 860 | | |
| |||
1095 | 1085 | | |
1096 | 1086 | | |
1097 | 1087 | | |
1098 | | - | |
| 1088 | + | |
0 commit comments