Commit e405aaf
Address PR #371 AI review R1: REGISTRY contradiction + surface tightening
P3 fixes from CI reviewer round 1:
- REGISTRY.md `Note (Phase 3 by_path ...)`: drop "Placebos" from the
"remain sample-level summaries" sentence (TWFE diagnostic stays
sample-level; placebos are now per-path under the new sub-bullet).
Resolves the in-note contradiction the reviewer flagged.
- ChaisemartinDHaultfoeuilleResults docstring: add the
`path_placebo_event_study` Attributes block entry alongside
`path_effects`, documenting the negative-int inner-key convention
and the inherited cross-path cohort-sharing deviation.
- TestByPathPlacebo.test_attr_is_none_when_placebo_false: use the
same `_by_path_placebo_data()` fixture for both placebo-off and
placebo-on branches, so the difference is attributable solely to
the `placebo` flag (not a fixture swap).
- TestByPathPlacebo.test_path_placebo_point_estimate_within_path_mean:
replace the finiteness-only check with an explicit recomputation of
the within-path-mean DID^pl identity from the raw data, asserting
equality at atol=1e-10 / rtol=1e-10. Pins the estimand identity
against silent regressions in the per-path IF construction.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent ed7acc3 commit e405aaf
3 files changed
Lines changed: 105 additions & 15 deletions
File tree
- diff_diff
- docs/methodology
- tests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
374 | 374 | | |
375 | 375 | | |
376 | 376 | | |
| 377 | + | |
| 378 | + | |
| 379 | + | |
| 380 | + | |
| 381 | + | |
| 382 | + | |
| 383 | + | |
| 384 | + | |
| 385 | + | |
| 386 | + | |
| 387 | + | |
| 388 | + | |
| 389 | + | |
| 390 | + | |
377 | 391 | | |
378 | 392 | | |
379 | 393 | | |
| |||
0 commit comments