Commit e592a5b
committed
PR #457 R9 polish: fix inverted-boundary wording in docstring example
R9 verdict was Looks good with 1 P3 informational item: the
bacon_decompose docstring example said per-component parity holds
"when first_treat is bounded below by min(time)" — that's the
inverse of the correct condition. Under the library's `<= min(time)`
remap rule, always-treated panels are exactly the ones WITH at least
one non-sentinel `first_treat <= min(time)`, so per-component parity
holds when all non-sentinel cohorts have `first_treat > min(time)`
(i.e. bounded *above* by min(time), or equivalently "no first-
period-treated cohorts"). Rephrased.
Tests: 34/34 pass; no behavior change (docstring-only fix).1 parent 9210aeb commit e592a5b
1 file changed
Lines changed: 8 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1312 | 1312 | | |
1313 | 1313 | | |
1314 | 1314 | | |
1315 | | - | |
1316 | | - | |
1317 | | - | |
1318 | | - | |
1319 | | - | |
1320 | | - | |
1321 | | - | |
| 1315 | + | |
| 1316 | + | |
| 1317 | + | |
| 1318 | + | |
| 1319 | + | |
| 1320 | + | |
| 1321 | + | |
| 1322 | + | |
1322 | 1323 | | |
1323 | 1324 | | |
1324 | 1325 | | |
| |||
0 commit comments