Commit e73a6c4
committed
PR #457 R1 polish: qualify docstring parity claim + refresh skip message
R1 verdict was Looks good with 2 P3 informational items. Both addressed:
1. P3 (Documentation/Tests): `bacon_decompose()` docstring example
said "matches R bacondecomp::bacon() at atol=1e-6" without mentioning
the documented always-treated convention exception. Qualified the
example to spell out the aggregate-vs-per-component split:
aggregate parity holds for all panels at atol=1e-6, per-component
parity holds when first_treat is bounded below by min(time) (no
always-treated), and the divergence on always-treated panels is by
convention (Python remap-to-U vs R's `Later vs Always Treated`).
Cross-references the REGISTRY note for the full contract.
2. P3 (Documentation/Tests): `TestBaconParityR`'s skip message still
said the goldens were "deferred until R is provisioned (see TODO.md)"
but the TODO row was removed in this PR. Updated to describe the
intended skip case (partial-checkout / packaging scenarios where
the committed JSON is unavailable) and dropped the TODO reference.
Tests unchanged: 33/33 pass in test_methodology_bacon.py.1 parent 7beef1a commit e73a6c4
2 files changed
Lines changed: 13 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1302 | 1302 | | |
1303 | 1303 | | |
1304 | 1304 | | |
1305 | | - | |
1306 | | - | |
| 1305 | + | |
| 1306 | + | |
| 1307 | + | |
| 1308 | + | |
| 1309 | + | |
| 1310 | + | |
| 1311 | + | |
| 1312 | + | |
| 1313 | + | |
1307 | 1314 | | |
1308 | 1315 | | |
1309 | 1316 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
301 | 301 | | |
302 | 302 | | |
303 | 303 | | |
304 | | - | |
| 304 | + | |
305 | 305 | | |
306 | 306 | | |
307 | | - | |
308 | | - | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
309 | 310 | | |
310 | 311 | | |
311 | 312 | | |
| |||
0 commit comments