Skip to content

Commit ebd9cb2

Browse files
igerberclaude
andcommitted
Address PR #110 feedback round 9: fix test fixture mismatch
Update mock return value for _rust_loocv_grid_search to include the 7th value (first_failed_obs) that was added in round 8. The mock was returning 6 values but the actual Rust function returns 7. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1 parent 835ade2 commit ebd9cb2

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

tests/test_trop.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2081,8 +2081,8 @@ def test_rust_infinite_score_triggers_fallback(self, simple_panel_data):
20812081
)
20822082

20832083
# Mock Rust function to return infinite score
2084-
# Return format: (lambda_time, lambda_unit, lambda_nn, score, n_valid, n_attempted)
2085-
mock_rust_loocv = MagicMock(return_value=(0.5, 0.5, 0.05, np.inf, 0, 100))
2084+
# Return format: (lambda_time, lambda_unit, lambda_nn, score, n_valid, n_attempted, first_failed_obs)
2085+
mock_rust_loocv = MagicMock(return_value=(0.5, 0.5, 0.05, np.inf, 0, 100, None))
20862086

20872087
# Also mock Python LOOCV to return infinity (so Python fallback also fails)
20882088
def always_infinity(*args, **kwargs):

0 commit comments

Comments
 (0)