Commit f3518d1
Address CI review findings: secret scan, block parser, tiered matching, pricing
P0: Expand secret scan (Step 3c) to cover full source files, import-expanded
files, and --include-files — not just diff hunks
P1: Rewrite parse_review_findings() as block-based parser supporting multi-line
Severity/Impact/Concrete-fix format. Add fail-safe: when parsing yields zero
findings but severity markers exist, preserve prior findings instead of marking
all as addressed. Return type changed to tuple[list[dict], bool].
P1: Implement tiered finding matching — primary key uses (severity, file_basename,
summary[:50]) when file path available; fallback uses (severity, summary[:50])
only for findings without file paths and only with unique candidates. Prevents
cross-file misattribution while still handling missing locations.
P1: Fix estimate_cost() to match longest model prefix first, so gpt-4.1-mini
and o3-mini snapshots get correct mini-tier pricing instead of parent.
P1: Add branch/base validation to review-state.json reuse in skill Step 4.
Discard stale state when stored branch or base_ref doesn't match current.
P2: In delta mode, derive source/import context from delta changed-files list
instead of full branch changed-files.
P2: Add 7 regression tests: multi-line parser, parse uncertainty flag,
same-summary-different-files, mini pricing, o3-mini pricing, delta context
derivation, branch/base validation support.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>1 parent 68eb149 commit f3518d1
3 files changed
Lines changed: 418 additions & 164 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
156 | 156 | | |
157 | 157 | | |
158 | 158 | | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
159 | 204 | | |
160 | 205 | | |
161 | | - | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
162 | 209 | | |
163 | 210 | | |
164 | 211 | | |
165 | 212 | | |
166 | | - | |
| 213 | + | |
167 | 214 | | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
168 | 224 | | |
169 | 225 | | |
170 | 226 | | |
| |||
0 commit comments