Skip to content

Commit f94a88a

Browse files
igerberclaude
andcommitted
Adjust path_heterogeneity_effects docstring to OLS/WLS dual path
R2 review caught one more stale "WLS" reference in the result-class docstring: `path_heterogeneity_effects` described `beta` as a WLS coefficient, but the non-survey path is plain OLS (only the survey branch is WLS). Clarify that `beta` is OLS on the non-survey path and WLS-on-pweights only under `survey_design`. The global `heterogeneity_effects` docstring is already generic ("Per-horizon heterogeneity test results") and needs no change. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 21ffbcb commit f94a88a

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

diff_diff/chaisemartin_dhaultfoeuille_results.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -430,8 +430,9 @@ class ChaisemartinDHaultfoeuilleResults:
430430
``paths_of_interest=[(...), ...]``) is set. Inner dict keyed by
431431
horizon directly (no ``"horizons"`` wrapper); each entry holds
432432
``{"beta", "se", "t_stat", "p_value", "conf_int", "n_obs"}``,
433-
where ``beta`` is the WLS coefficient on the heterogeneity
434-
covariate on the path-restricted switcher subsample. Cohort
433+
where ``beta`` is the heterogeneity coefficient on the path-
434+
restricted switcher subsample - plain OLS on the non-survey
435+
path, WLS-on-pweights under ``survey_design``. Cohort
435436
dummies in the design matrix absorb baseline by construction.
436437
Empty-state contract mirrors ``path_effects``: ``None`` when not
437438
requested; ``{}`` when requested but no path has eligible

0 commit comments

Comments
 (0)