Commit f9f951f
Fix
Per REGISTRY's pretest workflow (lines 2482-2487 surrounding the
four-step enumeration) and the same module's two correctly-framed
docstrings (module-level at line 54, `_compose_verdict_event_study` at
line 2735), paper Step 4 is the decision rule "use TWFE if none of the
tests rejects" — NOT a test or assumption. The Yatchew-HR test is a
Step 3 alternative (a single-horizon swap-in for Stute), and there is
no joint Yatchew variant in the paper.
The `did_had_pretest_workflow()` docstring at L4445-4446 was the only
place in the file that mislabeled the Yatchew alternative as "Step 4".
Reword to:
- correctly tag Yatchew as a step-3 alternative
- explicitly state Step 4 is the decision rule with no code path
- cross-reference the two existing correctly-framed docstrings in the
same file so future readers can confirm the convention is consistent
Surfaced by PR #409 R6 review (T21 tutorial pre-test taxonomy work
made the inconsistency visible). All 42 workflow-specific tests in
`tests/test_had_pretests.py` still pass; T21 drift test (16 tests)
still passes.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>did_had_pretest_workflow() docstring: paper Step 4 is the decision rule1 parent 162f45a commit f9f951f
1 file changed
Lines changed: 9 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4442 | 4442 | | |
4443 | 4443 | | |
4444 | 4444 | | |
4445 | | - | |
4446 | | - | |
4447 | | - | |
4448 | | - | |
4449 | | - | |
| 4445 | + | |
| 4446 | + | |
| 4447 | + | |
| 4448 | + | |
| 4449 | + | |
| 4450 | + | |
| 4451 | + | |
| 4452 | + | |
| 4453 | + | |
4450 | 4454 | | |
4451 | 4455 | | |
4452 | 4456 | | |
| |||
0 commit comments