Skip to content

Commit fe3d79a

Browse files
authored
Merge pull request #208 from igerber/power-analysis
Extend power analysis to all estimators + simulation-based MDE/sample size
2 parents c505c19 + d1dadfe commit fe3d79a

8 files changed

Lines changed: 2980 additions & 268 deletions

File tree

TODO.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ Deferred items from PR reviews that were not addressed before merge.
5252
| ImputationDiD dense `(A0'A0).toarray()` scales O((U+T+K)^2), OOM risk on large panels | `imputation.py` | #141 | Medium (deferred — only triggers when sparse solver fails; fixing requires sparse least-squares alternatives) |
5353
| EfficientDiD: warn when cohort share is very small (< 2 units or < 1% of sample) — inverted in Omega*/EIF | `efficient_did_weights.py` | #192 | Low |
5454
| EfficientDiD: API docs / tutorial page for new public estimator | `docs/` | #192 | Medium |
55+
| TripleDifference power: `generate_ddd_data` is a fixed 2×2×2 cross-sectional DGP — no multi-period or unbalanced-group support. Add a `generate_ddd_panel_data` for panel DDD power analysis. | `prep_dgp.py`, `power.py` | #208 | Low |
5556

5657
#### Performance
5758

diff_diff/__init__.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,11 +53,15 @@
5353
from diff_diff.power import (
5454
PowerAnalysis,
5555
PowerResults,
56+
SimulationMDEResults,
5657
SimulationPowerResults,
58+
SimulationSampleSizeResults,
5759
compute_mde,
5860
compute_power,
5961
compute_sample_size,
62+
simulate_mde,
6063
simulate_power,
64+
simulate_sample_size,
6165
)
6266
from diff_diff.pretrends import (
6367
PreTrendsPower,
@@ -291,11 +295,15 @@
291295
# Power analysis
292296
"PowerAnalysis",
293297
"PowerResults",
298+
"SimulationMDEResults",
294299
"SimulationPowerResults",
300+
"SimulationSampleSizeResults",
295301
"compute_mde",
296302
"compute_power",
297303
"compute_sample_size",
304+
"simulate_mde",
298305
"simulate_power",
306+
"simulate_sample_size",
299307
"plot_power_curve",
300308
# Pre-trends power analysis
301309
"PreTrendsPower",

0 commit comments

Comments
 (0)