Skip to content
This repository was archived by the owner on Jun 15, 2020. It is now read-only.
This repository was archived by the owner on Jun 15, 2020. It is now read-only.

netbuf memory leak #8

@FreddySpencer

Description

@FreddySpencer

http_handle_connection():
the call netbuf_delete(inbuf) must be moved inside the while loop:

while (ctx->state != HTTP_REQUEST_DONE) {
    err = netconn_recv(conn, &inbuf);
    if (err != ERR_OK) {
        break;
    }

    err = netbuf_data(inbuf, (void**) &buf, &buflen);
    if (err != ERR_OK) {
        break;
    }

    size_t parsed_bytes = http_parser_execute(&ctx->parser, &parser_settings, buf, buflen);
    netbuf_delete(inbuf);
    if (parsed_bytes < buflen) {
        break;
    }
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions