Added REST api for announcement app #63
Conversation
|
@RajuKoushik Added Serializable class for taggit . Review it again Sir. |
|
@yashLadha: Please deploy this branch on cloud and share link. |
|
Sir, @singhpratyush Is AWS free for students? |
|
It has a free tier for first year. |
|
Sir, should i deploy it to heroku or any other because for heroku i need to change settings for it and may be it won't consistent with the current system. |
|
I recommend using AWS. You can simply run |
|
Sir, currently i do not own my self a card. IS there a free alternative of it. |
|
@singhpratyush I can share the images of testing the api with postman. |
wsgi/odyssy/announcement/api/urls.py
Outdated
| ) | ||
|
|
||
| urlpatterns = [ | ||
| url(r'^$', AnnouncementListView.as_view(), name='all-announcement'), |
There was a problem hiding this comment.
@yashLadha sir name='all-announcement' can we use some different name here as the name name='all_announcement' is already used in announcement app's urls and it might get confusing later.
There was a problem hiding this comment.
It would be more relevant if it would be api_all_announcement. View @Monal5031 . Now it is more connected to only the api.
There was a problem hiding this comment.
It'd be good if we could see the working of this REST api. Bugs can be found that way. Views @yashLadha ?
|
Actually I can't setup it on AWS as i don't own a card. Is there any
alternative.
…On 25 Jun 2017 5:45 pm, "Monal Shadi" ***@***.***> wrote:
***@***.**** commented on this pull request.
It'd be good if we could see the working of this REST api. Bugs can be
found that way.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#63 (review)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ARMqT9Sn9wwHDD56fqDvDBir_eJ-lZG8ks5sHk9kgaJpZM4N1M_U>
.
|
|
@yashLadha sir please update this PR, so we can merge it 😄 |
|
May be we should wait for other's to also add their review?? |
|
Yeah 👍 |
|
Not relevant |
Closes #50