Milestone 21: Prevent duplicate ui_accept SFX and expand input guard tests, Part #5

[ikostan]

Prevent duplicate ui_accept SFX and expand input guard tests

Strengthen UI input audio guarding and documentation around CI maintenance workflows to prevent duplicate confirmation sounds and capture recent automation updates.

Overall Impact: The PR strengthens audio input handling to prevent duplicates, expands test coverage for UI controls (buttons, sliders, LineEdit, TextEdit, etc.), and documents bot/AI-driven CI maintenance. Automation significantly reduced manual effort while maintaining quality.

---

Bug Fixes:

• Ensure global ui_accept audio is bypassed when focused interactive controls handle their own confirmation sounds to avoid double-triggered audio.

Enhancements:

• Refactored UI input guard tests to use a shared helper and expanded coverage to additional controls including sliders, buttons, and text inputs.
• Added a functional test to verify that deferred button press hooks correctly route audio playback through AudioManager.

Documentation:

• Documented CI maintenance and workflow dependency updates in a milestone maintenance note, including the role of bots and AI tools in keeping GitHub Actions up to date.
• Added a maintenance update covering workflow dependency refreshes, pinned action revisions, and reviewer guidance.

Tests

• Added coverage to verify button presses trigger audio feedback.
• Added checks to ensure the global accept action does not play sounds while editing text in input fields.

---

Reviewer's Guide

Adds regression tests and helpers around UI confirmation audio safeguards, verifies deferred button press audio routing, documents CI workflow maintenance, and clarifies the ui_accept focus guard in Globals.

File-Level Changes

Change	Details	Files
Clarified the ui_accept focus guard in the global input handler to avoid duplicate confirmation audio when interactive controls have focus.	Documented that the global input loop must bypass ui_accept when a focused interactive control handles its own audio via pressed signals. Linked the guard behavior explicitly to bug [BUG] UI confirmation audio (ui_accept) double-triggers when using keyboard/gamepad to select standard menu buttons #787 to explain the intent around duplicate confirmation sounds.	scripts/core/globals.gd
Refactored and expanded UI input guard tests to use shared helpers and cover additional focused controls, including text inputs.	Introduced _assert_focus_blocks_action and _assert_focus_blocks_ui_accept helpers to centralize setup, input dispatch, and assertions. Updated existing tests for CheckButton, HSlider, and Button to use the new helpers and removed duplicated Arrange/Act/Assert logic. Added new tests ensuring LineEdit and TextEdit focus suppress global ui_accept audio and tightened comments around focus/navigation coverage. Kept AudioManager cleanup in after_each and removed redundant per-test cleanup where appropriate.	test/gut/test_globals_input_guards.gd
Added functional coverage to ensure deferred button press hooks route audio playback through AudioManager.	Created a test that instantiates a standard Button, registers it through the existing tracking helper, and clears AudioManager state. Simulated a pressed signal emission, yielded a frame for deferred connections, and asserted that AudioManager reports SFX playback.	test/gut/test_globals_button_hooks.gd
Documented the ui_accept fix, expanded test coverage, and CI workflow maintenance in milestone documentation, including automation roles.	Added a milestone document describing the duplicate ui_accept SFX fix, expanded input guard tests, and button hook coverage. Documented CI workflow maintenance, including bumps to actions/cache, release-drafter, and github/codeql-action/upload-sarif, plus reviewer guidance. Recorded the roles of bots/AI tools and human contributors in CI maintenance and this PR’s implementation.	files/docs/milestones/21/Part_5_Prevent_duplicate_ui_accept_SFX.md files/docs/milestones/21/Part_4_Maintenance.md

Assessment against linked issues

Issue	Objective	Addressed	Explanation
#787	Ensure that pressing ui_accept (Enter/Space or controller equivalent) on standard menu buttons plays the confirmation audio exactly once by preventing the global input handler from triggering audio when an interactive control (e.g., BaseButton) has focus.	✅
#787	Add regression tests that cover UI input audio safeguards (focused controls bypass global ui_accept playback) and verify that button press hooks correctly trigger AudioManager playback via deferred connections.	✅

---

Bots/AI Contributions to PR #803

This PR primarily addresses a UI confirmation audio double-trigger bug for ui_accept events (linked to issue #787), adds/enhances GUT unit tests for global audio hooks and input guards, and includes maintenance documentation for CI workflow updates. While human oversight integrated the changes, bots and AI tools handled the bulk of dependency updates, code reviews, summaries, refactoring suggestions, and quality checks.

AI/Bot Contributors

• @dependabot — Primary driver of CI dependency updates (e.g., bumping actions/cache from v5 to v6, refreshing pinned SHAs for release-drafter/release-drafter and github/codeql-action/upload-sarif across multiple workflows like browser_test.yml, deploy_to_itch.yml, security scans, etc.). Automated commits were merged into this PR.
• @sourcery-ai — Generated automated PR summaries, reviewer's guides, enhancement suggestions, and contributed to documentation refinements (e.g., workflow count fixes in Part_4_Maintenance.md). Provided structured analysis of changes, related PR context, and estimated review effort.
• @coderabbitai — Delivered detailed walkthroughs, file-level summaries, nitpick comments (e.g., test refactoring for duplication in input guards), actionable suggestions, and poems. Co-authored commits for test updates and improvements based on review feedback. Also suggested finishing touches like unit test generation.
• @deepsource-io (DeepSourceReview) — Performed automated code reviews with a PR Report Card covering Security, Reliability, Complexity, and Hygiene for Python/JavaScript analyzers. Provided inline comments and overall quality validation.

These tools collectively managed most technical updates, validation, documentation polishing, and review processes, showcasing effective automation for CI hygiene and test coverage.

Human Contributors

• @ikostan — Opened the PR, implemented the core bug fix in globals.gd, added/expanded tests (test_globals_button_hooks.gd, test_globals_input_guards.gd), created and refined the maintenance doc (Part_4_Maintenance.md), merged bot contributions, applied labels (bug, testing, CI/CD, etc.), self-assigned, and handled milestone/project tracking.
• @espanakosta-jpg — No direct commits or reviews visible in this PR's timeline (potential upstream or related context contributions).

---

---

This discussion was created from the release Milestone 21: Prevent duplicate ui_accept SFX and expand input guard tests, Part #5.