From 87695df5f7e483db15cdcabbc30af94c5b3ba9dd Mon Sep 17 00:00:00 2001
From: Egor Kostan <20955183+ikostan@users.noreply.github.com>
Date: Fri, 14 Aug 2026 21:34:25 -0700
Subject: [PATCH 01/35] Add telemetry hook and normalize handlers
Consolidates engine configuration by merging a custom onProgress telemetry hook that logs assembly transfer percent, and initializes Engine with the merged config. Updates the loading UI comment to mention accessibility and normalizes multiple button handler assignments by removing inline comments/formatting. Small refactor/cleanup in custom_shell.html to add telemetry and improve clarity.
---
custom_shell.html | 31 +++++++++++++++++++++----------
1 file changed, 21 insertions(+), 10 deletions(-)
diff --git a/custom_shell.html b/custom_shell.html
index adca2787a..9f6052ff9 100644
--- a/custom_shell.html
+++ b/custom_shell.html
@@ -188,13 +188,24 @@
From 11e2936a56249c9f07d4c36baa33527b08a410cf Mon Sep 17 00:00:00 2001
From: Egor Kostan <20955183+ikostan@users.noreply.github.com>
Date: Fri, 14 Aug 2026 21:45:28 -0700
Subject: [PATCH 02/35] Create splash_transition_flow_test.py
---
tests/splash_transition_flow_test.py | 168 +++++++++++++++++++++++++++
1 file changed, 168 insertions(+)
create mode 100644 tests/splash_transition_flow_test.py
diff --git a/tests/splash_transition_flow_test.py b/tests/splash_transition_flow_test.py
new file mode 100644
index 000000000..d750092f3
--- /dev/null
+++ b/tests/splash_transition_flow_test.py
@@ -0,0 +1,168 @@
+# Copyright (C) 2025-2026 Egor Kostan
+# SPDX-License-Identifier: GPL-3.0-or-later
+# tests/splash_transition_flow_test.py
+"""
+Splash Screen Transition & Telemetry Test Suite (Playwright + UI Automation)
+=============================================================================
+
+Overview
+--------
+Verifies the asynchronous web loading workflow, custom shell initialization pipeline,
+and in-game progress transition mechanics. Eliminates race conditions by validating
+orderly handshakes between the DOM layout engine and the WebAssembly runtime graphics context.
+
+Prerequisites
+-------------
+- http://localhost:8080/index.html (HTML5 export with preloader & overlays)
+- pytest, playwright
+
+Running
+-------
+pytest -k splash_transition_flow -q
+
+Artifacts
+---------
+v8_coverage_splash_transition_flow_test.json, artifacts/test_splash_failure_*.png/txt/html
+"""
+
+import json
+import os
+import time
+from typing import Any
+
+from playwright.sync_api import Page, expect
+
+from tests.test_utils import DEFAULT_TIMEOUT, TEST_TIMEOUT
+
+
+# DO NOT REFACTOR: Must consume function-scoped `page` to capture preloader & startup telemetry.
+def test_splash_transition_flow(page: Page) -> None:
+ """
+ Validates assembly stream metrics, WebGL frame canvas presentation,
+ and the removal of preloader DOM layers without structural rendering anomalies.
+ """
+ logs: list[dict[str, str]] = []
+ page_errors: list[str] = []
+ cdp_session = None
+
+ def on_console(msg: Any) -> None:
+ """Capture all console logs to track runtime lifecycle telemetry."""
+ logs.append({"type": msg.type, "text": msg.text})
+
+ def on_page_error(exc: Any) -> None:
+ """Capture uncaught runtime errors during engine boot."""
+ page_errors.append(f"Uncaught Exception: {exc.message}\n{exc.stack}")
+
+ # Register listeners BEFORE page navigation
+ page.on("console", on_console)
+ page.on("pageerror", on_page_error)
+
+ try:
+ # 1. INITIALIZE V8 PRECISE COVERAGE VIA CDP
+ cdp_session = page.context.new_cdp_session(page)
+ cdp_session.send("Profiler.enable")
+ cdp_session.send(
+ "Profiler.startPreciseCoverage", {"callCount": True, "detailed": True}
+ )
+
+ # 2. MONITOR INITIAL BROWSER LOADING LAYER
+ page.goto(
+ "http://localhost:8080/index.html",
+ wait_until="domcontentloaded",
+ timeout=DEFAULT_TIMEOUT,
+ )
+
+ # Verify custom HTML layout preloader maps instantly to the viewport
+ loading_overlay = page.locator("#loading")
+ expect(loading_overlay).to_be_visible(timeout=TEST_TIMEOUT)
+
+ # 3. VERIFY ENGINE INITIALIZATION & RUNTIME TELEMETRY
+ page.wait_for_function(
+ "() => window.godotInitialized === true", timeout=DEFAULT_TIMEOUT
+ )
+
+ # Confirm the customized configuration object processed data transfers
+ transfer_logs = [
+ log["text"]
+ for log in logs
+ if "Telemetry - Assembly Transfer:" in log["text"]
+ ]
+ assert (
+ len(transfer_logs) > 0
+ ), "No 'Telemetry - Assembly Transfer:' telemetry marks captured during load."
+
+ # 4. ASSIGN RENDERING CANVAS HANDSHAKE INVARIANTS
+ canvas_element = page.locator("#canvas")
+ expect(canvas_element).to_be_visible(timeout=TEST_TIMEOUT)
+ assert (
+ "SkyLockAssault" in page.title()
+ ), f"Unexpected page execution title: '{page.title()}'"
+
+ # Verify HTML shell overlay deflates cleanly out of view
+ expect(loading_overlay).to_be_hidden(timeout=TEST_TIMEOUT)
+ assert page.evaluate(
+ "() => document.getElementById('loading').getAttribute('aria-hidden') === 'true'"
+ ), "Loading container missing aria-hidden='true' post-initialization"
+
+ # 5. AUDIT FATAL PARSING & SCRIPT COMPILATION EXCEPTIONS
+ critical_faults = [
+ log["text"]
+ for log in logs
+ if log["type"] == "error"
+ and not any(
+ phrase in log["text"].lower()
+ for phrase in ["encryption aborted", "salt is empty"]
+ )
+ ] + page_errors
+
+ assert (
+ len(critical_faults) == 0
+ ), f"Critical exceptions found during web handshake:\n" + "\n".join(critical_faults)
+
+ except Exception as e:
+ print(f"Test: 'test_splash_transition_flow' failed: {e!s}")
+ os.makedirs("artifacts", exist_ok=True)
+ timestamp: int = int(time.time())
+
+ # Isolate diagnostic files on execution crashes
+ page.screenshot(path=f"artifacts/test_splash_failure_screenshot_{timestamp}.png")
+
+ with open(
+ f"artifacts/test_splash_failure_console_logs_{timestamp}.txt",
+ "w",
+ encoding="utf-8",
+ ) as f:
+ f.write("--- CONSOLE LOGS ---\n")
+ for log in logs:
+ f.write(f"[{log['type']}] {log['text']}\n")
+ f.write("\n--- PAGE ERRORS ---\n")
+ for p_err in page_errors:
+ f.write(f"{p_err}\n")
+
+ with open(
+ f"artifacts/test_splash_failure_html_{timestamp}.html",
+ "w",
+ encoding="utf-8",
+ ) as f:
+ f.write(page.content())
+ raise
+
+ finally:
+ try:
+ page.remove_listener("console", on_console)
+ page.remove_listener("pageerror", on_page_error)
+ except Exception:
+ pass
+
+ if cdp_session:
+ try:
+ coverage = cdp_session.send("Profiler.takePreciseCoverage")["result"]
+ cdp_session.send("Profiler.stopPreciseCoverage")
+ cdp_session.send("Profiler.disable")
+ cdp_session.detach()
+ with open(
+ "v8_coverage_splash_transition_flow_test.json", "w", encoding="utf-8"
+ ) as f:
+ json.dump(coverage, f)
+ except Exception as cov_err:
+ print(f"Warning: Failed to harvest V8 coverage data: {cov_err}")
From cafa39656cefcb72e63e2b1facdb8661d147ac65 Mon Sep 17 00:00:00 2001
From: Egor Kostan <20955183+ikostan@users.noreply.github.com>
Date: Fri, 14 Aug 2026 21:47:29 -0700
Subject: [PATCH 03/35] Add canvas geometry assertions to splash test
tests/splash_transition_flow_test.py: update comment to include GEOMETRY and add assertions verifying canvas_element.bounding_box() is not None and that its width/height are > 0. Ensures the rendering canvas is actually laid out (detects headless/renderer failures) during the splash transition test.
---
tests/splash_transition_flow_test.py | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/tests/splash_transition_flow_test.py b/tests/splash_transition_flow_test.py
index d750092f3..c5a27182f 100644
--- a/tests/splash_transition_flow_test.py
+++ b/tests/splash_transition_flow_test.py
@@ -91,9 +91,15 @@ def on_page_error(exc: Any) -> None:
len(transfer_logs) > 0
), "No 'Telemetry - Assembly Transfer:' telemetry marks captured during load."
- # 4. ASSIGN RENDERING CANVAS HANDSHAKE INVARIANTS
+ # 4. ASSIGN RENDERING CANVAS HANDSHAKE & GEOMETRY INVARIANTS
canvas_element = page.locator("#canvas")
expect(canvas_element).to_be_visible(timeout=TEST_TIMEOUT)
+
+ canvas_box = canvas_element.bounding_box()
+ assert canvas_box is not None, "Canvas has no rendered bounding box"
+ assert canvas_box["width"] > 0, "Canvas rendered width is zero"
+ assert canvas_box["height"] > 0, "Canvas rendered height is zero"
+
assert (
"SkyLockAssault" in page.title()
), f"Unexpected page execution title: '{page.title()}'"
From 815c46e2bb5d460c1bf613974326af30a7e62e83 Mon Sep 17 00:00:00 2001
From: Egor Kostan <20955183+ikostan@users.noreply.github.com>
Date: Fri, 14 Aug 2026 21:50:13 -0700
Subject: [PATCH 04/35] Enhance splash transition telemetry checks
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Parse 'Telemetry - Assembly Transfer: X%' marks using regex and assert their presence, bounds (0–100), and monotonic progression. Added re import, improved test docstring and comments, and strengthened canvas/title assertion messages. Added invariant check that window.godotInitialized remains true after overlay teardown. Miscellaneous readability tweaks.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---
tests/splash_transition_flow_test.py | 55 ++++++++++++++++++----------
1 file changed, 35 insertions(+), 20 deletions(-)
diff --git a/tests/splash_transition_flow_test.py b/tests/splash_transition_flow_test.py
index c5a27182f..f6096d6bc 100644
--- a/tests/splash_transition_flow_test.py
+++ b/tests/splash_transition_flow_test.py
@@ -8,8 +8,9 @@
Overview
--------
Verifies the asynchronous web loading workflow, custom shell initialization pipeline,
-and in-game progress transition mechanics. Eliminates race conditions by validating
-orderly handshakes between the DOM layout engine and the WebAssembly runtime graphics context.
+progressive assembly telemetry, and in-game progress transition mechanics. Eliminates
+race conditions by validating orderly handshakes between the DOM layout engine and the
+WebAssembly runtime graphics context.
Prerequisites
-------------
@@ -27,6 +28,7 @@
import json
import os
+import re
import time
from typing import Any
@@ -38,8 +40,8 @@
# DO NOT REFACTOR: Must consume function-scoped `page` to capture preloader & startup telemetry.
def test_splash_transition_flow(page: Page) -> None:
"""
- Validates assembly stream metrics, WebGL frame canvas presentation,
- and the removal of preloader DOM layers without structural rendering anomalies.
+ Validates assembly stream metrics, progressive telemetry monotonicity,
+ WebGL frame canvas presentation, and orderly removal of preloader DOM layers.
"""
logs: list[dict[str, str]] = []
page_errors: list[str] = []
@@ -53,7 +55,7 @@ def on_page_error(exc: Any) -> None:
"""Capture uncaught runtime errors during engine boot."""
page_errors.append(f"Uncaught Exception: {exc.message}\n{exc.stack}")
- # Register listeners BEFORE page navigation
+ # Register listeners BEFORE navigation to capture early boot telemetry & errors
page.on("console", on_console)
page.on("pageerror", on_page_error)
@@ -81,36 +83,49 @@ def on_page_error(exc: Any) -> None:
"() => window.godotInitialized === true", timeout=DEFAULT_TIMEOUT
)
- # Confirm the customized configuration object processed data transfers
- transfer_logs = [
- log["text"]
- for log in logs
- if "Telemetry - Assembly Transfer:" in log["text"]
- ]
+ # Parse progressive assembly transfer marks ("Telemetry - Assembly Transfer: X%")
+ progress_values: list[int] = []
+ for log in logs:
+ match = re.search(r"Telemetry - Assembly Transfer:\s*(\d+)%", log["text"])
+ if match:
+ progress_values.append(int(match.group(1)))
+
+ # Assert telemetry presence, range bounds, and monotonic forward progression
assert (
- len(transfer_logs) > 0
- ), "No 'Telemetry - Assembly Transfer:' telemetry marks captured during load."
+ len(progress_values) > 0
+ ), "No 'Telemetry - Assembly Transfer:' marks captured during engine boot."
+ assert all(
+ 0 <= val <= 100 for val in progress_values
+ ), f"Telemetry percentage out of bounds [0, 100]: {progress_values}"
+ assert (
+ progress_values == sorted(progress_values)
+ ), f"Assembly transfer telemetry did not progress monotonically: {progress_values}"
- # 4. ASSIGN RENDERING CANVAS HANDSHAKE & GEOMETRY INVARIANTS
+ # 4. ASSIGN RENDERING CANVAS HANDSHAKE & STRUCTURAL GEOMETRY
canvas_element = page.locator("#canvas")
expect(canvas_element).to_be_visible(timeout=TEST_TIMEOUT)
canvas_box = canvas_element.bounding_box()
- assert canvas_box is not None, "Canvas has no rendered bounding box"
- assert canvas_box["width"] > 0, "Canvas rendered width is zero"
- assert canvas_box["height"] > 0, "Canvas rendered height is zero"
+ assert canvas_box is not None, "Canvas element has no rendered bounding box"
+ assert canvas_box["width"] > 0, "Canvas rendered width is zero (viewport layout failure)"
+ assert canvas_box["height"] > 0, "Canvas rendered height is zero (viewport layout failure)"
assert (
"SkyLockAssault" in page.title()
- ), f"Unexpected page execution title: '{page.title()}'"
+ ), f"Target application title mismatch: '{page.title()}'"
- # Verify HTML shell overlay deflates cleanly out of view
+ # 5. VERIFY DOM TEARDOWN & LIFECYCLE INVARIANTS
expect(loading_overlay).to_be_hidden(timeout=TEST_TIMEOUT)
assert page.evaluate(
"() => document.getElementById('loading').getAttribute('aria-hidden') === 'true'"
), "Loading container missing aria-hidden='true' post-initialization"
- # 5. AUDIT FATAL PARSING & SCRIPT COMPILATION EXCEPTIONS
+ # Invariant: engine initialization state must remain true after overlay teardown
+ assert page.evaluate(
+ "() => window.godotInitialized === true"
+ ), "window.godotInitialized lost its truthy state after splash transition completed"
+
+ # 6. AUDIT FATAL PARSING & SCRIPT COMPILATION EXCEPTIONS
critical_faults = [
log["text"]
for log in logs
From cbcc5ffbc4703abde312f271c11f5c2a495a3bc7 Mon Sep 17 00:00:00 2001
From: "deepsource-autofix[bot]"
<62050782+deepsource-autofix[bot]@users.noreply.github.com>
Date: Sat, 15 Aug 2026 04:52:18 +0000
Subject: [PATCH 05/35] style: format code with Black and isort
This commit fixes the style issues introduced in 815c46e according to the output
from Black and isort.
Details: https://github.com/ikostan/SkyLockAssault/pull/895
---
tests/splash_transition_flow_test.py | 24 +++++++++++++++++-------
1 file changed, 17 insertions(+), 7 deletions(-)
diff --git a/tests/splash_transition_flow_test.py b/tests/splash_transition_flow_test.py
index f6096d6bc..e4a25d13c 100644
--- a/tests/splash_transition_flow_test.py
+++ b/tests/splash_transition_flow_test.py
@@ -97,8 +97,8 @@ def on_page_error(exc: Any) -> None:
assert all(
0 <= val <= 100 for val in progress_values
), f"Telemetry percentage out of bounds [0, 100]: {progress_values}"
- assert (
- progress_values == sorted(progress_values)
+ assert progress_values == sorted(
+ progress_values
), f"Assembly transfer telemetry did not progress monotonically: {progress_values}"
# 4. ASSIGN RENDERING CANVAS HANDSHAKE & STRUCTURAL GEOMETRY
@@ -107,8 +107,12 @@ def on_page_error(exc: Any) -> None:
canvas_box = canvas_element.bounding_box()
assert canvas_box is not None, "Canvas element has no rendered bounding box"
- assert canvas_box["width"] > 0, "Canvas rendered width is zero (viewport layout failure)"
- assert canvas_box["height"] > 0, "Canvas rendered height is zero (viewport layout failure)"
+ assert (
+ canvas_box["width"] > 0
+ ), "Canvas rendered width is zero (viewport layout failure)"
+ assert (
+ canvas_box["height"] > 0
+ ), "Canvas rendered height is zero (viewport layout failure)"
assert (
"SkyLockAssault" in page.title()
@@ -138,7 +142,9 @@ def on_page_error(exc: Any) -> None:
assert (
len(critical_faults) == 0
- ), f"Critical exceptions found during web handshake:\n" + "\n".join(critical_faults)
+ ), f"Critical exceptions found during web handshake:\n" + "\n".join(
+ critical_faults
+ )
except Exception as e:
print(f"Test: 'test_splash_transition_flow' failed: {e!s}")
@@ -146,7 +152,9 @@ def on_page_error(exc: Any) -> None:
timestamp: int = int(time.time())
# Isolate diagnostic files on execution crashes
- page.screenshot(path=f"artifacts/test_splash_failure_screenshot_{timestamp}.png")
+ page.screenshot(
+ path=f"artifacts/test_splash_failure_screenshot_{timestamp}.png"
+ )
with open(
f"artifacts/test_splash_failure_console_logs_{timestamp}.txt",
@@ -182,7 +190,9 @@ def on_page_error(exc: Any) -> None:
cdp_session.send("Profiler.disable")
cdp_session.detach()
with open(
- "v8_coverage_splash_transition_flow_test.json", "w", encoding="utf-8"
+ "v8_coverage_splash_transition_flow_test.json",
+ "w",
+ encoding="utf-8",
) as f:
json.dump(coverage, f)
except Exception as cov_err:
From 4b737d937db68d8ce516317ee9c4f47b2c3be7cf Mon Sep 17 00:00:00 2001
From: Egor Kostan <20955183+ikostan@users.noreply.github.com>
Date: Fri, 14 Aug 2026 22:00:20 -0700
Subject: [PATCH 06/35] Cleanup & minor fixes in splash_transition_flow_test
Reflowed long docstrings/comments and split artifact listing for readability. Tightened logging/assert messages and multiline formatting for regex and function calls. Capture diagnostic paths into variables (screenshot/log/html) before writing. Handle CDP coverage response safely by extracting the "result" key. Overall non-functional cleanup and small robustness improvements to error handling and telemetry parsing.
---
tests/splash_transition_flow_test.py | 100 +++++++++++++++++----------
1 file changed, 62 insertions(+), 38 deletions(-)
diff --git a/tests/splash_transition_flow_test.py b/tests/splash_transition_flow_test.py
index f6096d6bc..abf942955 100644
--- a/tests/splash_transition_flow_test.py
+++ b/tests/splash_transition_flow_test.py
@@ -7,10 +7,10 @@
Overview
--------
-Verifies the asynchronous web loading workflow, custom shell initialization pipeline,
-progressive assembly telemetry, and in-game progress transition mechanics. Eliminates
-race conditions by validating orderly handshakes between the DOM layout engine and the
-WebAssembly runtime graphics context.
+Verifies the asynchronous web loading workflow, custom shell initialization
+pipeline, progressive assembly telemetry, and in-game progress transition
+mechanics. Eliminates race conditions by validating orderly handshakes
+between the DOM layout engine and the WebAssembly runtime graphics context.
Prerequisites
-------------
@@ -23,7 +23,8 @@
Artifacts
---------
-v8_coverage_splash_transition_flow_test.json, artifacts/test_splash_failure_*.png/txt/html
+v8_coverage_splash_transition_flow_test.json
+artifacts/test_splash_failure_*.png/txt/html
"""
import json
@@ -37,11 +38,12 @@
from tests.test_utils import DEFAULT_TIMEOUT, TEST_TIMEOUT
-# DO NOT REFACTOR: Must consume function-scoped `page` to capture preloader & startup telemetry.
+# DO NOT REFACTOR: Must consume function-scoped `page` to capture preloader
+# and early startup telemetry.
def test_splash_transition_flow(page: Page) -> None:
"""
Validates assembly stream metrics, progressive telemetry monotonicity,
- WebGL frame canvas presentation, and orderly removal of preloader DOM layers.
+ WebGL frame canvas presentation, and orderly removal of preloader DOM.
"""
logs: list[dict[str, str]] = []
page_errors: list[str] = []
@@ -55,7 +57,7 @@ def on_page_error(exc: Any) -> None:
"""Capture uncaught runtime errors during engine boot."""
page_errors.append(f"Uncaught Exception: {exc.message}\n{exc.stack}")
- # Register listeners BEFORE navigation to capture early boot telemetry & errors
+ # Register listeners BEFORE navigation to capture early boot telemetry
page.on("console", on_console)
page.on("pageerror", on_page_error)
@@ -64,7 +66,8 @@ def on_page_error(exc: Any) -> None:
cdp_session = page.context.new_cdp_session(page)
cdp_session.send("Profiler.enable")
cdp_session.send(
- "Profiler.startPreciseCoverage", {"callCount": True, "detailed": True}
+ "Profiler.startPreciseCoverage",
+ {"callCount": True, "detailed": True},
)
# 2. MONITOR INITIAL BROWSER LOADING LAYER
@@ -74,41 +77,53 @@ def on_page_error(exc: Any) -> None:
timeout=DEFAULT_TIMEOUT,
)
- # Verify custom HTML layout preloader maps instantly to the viewport
+ # Verify custom HTML layout preloader maps instantly to viewport
loading_overlay = page.locator("#loading")
expect(loading_overlay).to_be_visible(timeout=TEST_TIMEOUT)
# 3. VERIFY ENGINE INITIALIZATION & RUNTIME TELEMETRY
page.wait_for_function(
- "() => window.godotInitialized === true", timeout=DEFAULT_TIMEOUT
+ "() => window.godotInitialized === true",
+ timeout=DEFAULT_TIMEOUT,
)
- # Parse progressive assembly transfer marks ("Telemetry - Assembly Transfer: X%")
+ # Parse progressive assembly transfer marks
+ # Format: "Telemetry - Assembly Transfer: X%"
progress_values: list[int] = []
for log in logs:
- match = re.search(r"Telemetry - Assembly Transfer:\s*(\d+)%", log["text"])
+ match = re.search(
+ r"Telemetry - Assembly Transfer:\s*(\d+)%",
+ log["text"],
+ )
if match:
progress_values.append(int(match.group(1)))
- # Assert telemetry presence, range bounds, and monotonic forward progression
+ # Assert telemetry presence, range bounds, and progression
assert (
len(progress_values) > 0
- ), "No 'Telemetry - Assembly Transfer:' marks captured during engine boot."
+ ), "No 'Telemetry - Assembly Transfer:' marks captured during load."
assert all(
0 <= val <= 100 for val in progress_values
), f"Telemetry percentage out of bounds [0, 100]: {progress_values}"
- assert (
- progress_values == sorted(progress_values)
- ), f"Assembly transfer telemetry did not progress monotonically: {progress_values}"
+ assert progress_values == sorted(progress_values), (
+ "Assembly transfer telemetry did not progress monotonically: "
+ f"{progress_values}"
+ )
# 4. ASSIGN RENDERING CANVAS HANDSHAKE & STRUCTURAL GEOMETRY
canvas_element = page.locator("#canvas")
expect(canvas_element).to_be_visible(timeout=TEST_TIMEOUT)
canvas_box = canvas_element.bounding_box()
- assert canvas_box is not None, "Canvas element has no rendered bounding box"
- assert canvas_box["width"] > 0, "Canvas rendered width is zero (viewport layout failure)"
- assert canvas_box["height"] > 0, "Canvas rendered height is zero (viewport layout failure)"
+ assert (
+ canvas_box is not None
+ ), "Canvas element has no rendered bounding box"
+ assert (
+ canvas_box["width"] > 0
+ ), "Canvas rendered width is zero (viewport layout failure)"
+ assert (
+ canvas_box["height"] > 0
+ ), "Canvas rendered height is zero (viewport layout failure)"
assert (
"SkyLockAssault" in page.title()
@@ -117,13 +132,17 @@ def on_page_error(exc: Any) -> None:
# 5. VERIFY DOM TEARDOWN & LIFECYCLE INVARIANTS
expect(loading_overlay).to_be_hidden(timeout=TEST_TIMEOUT)
assert page.evaluate(
- "() => document.getElementById('loading').getAttribute('aria-hidden') === 'true'"
+ "() => document.getElementById('loading')"
+ ".getAttribute('aria-hidden') === 'true'"
), "Loading container missing aria-hidden='true' post-initialization"
- # Invariant: engine initialization state must remain true after overlay teardown
+ # Invariant: engine initialization state persists after overlay teardown
assert page.evaluate(
"() => window.godotInitialized === true"
- ), "window.godotInitialized lost its truthy state after splash transition completed"
+ ), (
+ "window.godotInitialized lost its truthy state after splash "
+ "transition completed"
+ )
# 6. AUDIT FATAL PARSING & SCRIPT COMPILATION EXCEPTIONS
critical_faults = [
@@ -138,7 +157,10 @@ def on_page_error(exc: Any) -> None:
assert (
len(critical_faults) == 0
- ), f"Critical exceptions found during web handshake:\n" + "\n".join(critical_faults)
+ ), (
+ "Critical exceptions found during web handshake:\n"
+ + "\n".join(critical_faults)
+ )
except Exception as e:
print(f"Test: 'test_splash_transition_flow' failed: {e!s}")
@@ -146,13 +168,15 @@ def on_page_error(exc: Any) -> None:
timestamp: int = int(time.time())
# Isolate diagnostic files on execution crashes
- page.screenshot(path=f"artifacts/test_splash_failure_screenshot_{timestamp}.png")
+ screenshot_path = (
+ f"artifacts/test_splash_failure_screenshot_{timestamp}.png"
+ )
+ page.screenshot(path=screenshot_path)
- with open(
- f"artifacts/test_splash_failure_console_logs_{timestamp}.txt",
- "w",
- encoding="utf-8",
- ) as f:
+ logs_path = (
+ f"artifacts/test_splash_failure_console_logs_{timestamp}.txt"
+ )
+ with open(logs_path, "w", encoding="utf-8") as f:
f.write("--- CONSOLE LOGS ---\n")
for log in logs:
f.write(f"[{log['type']}] {log['text']}\n")
@@ -160,11 +184,8 @@ def on_page_error(exc: Any) -> None:
for p_err in page_errors:
f.write(f"{p_err}\n")
- with open(
- f"artifacts/test_splash_failure_html_{timestamp}.html",
- "w",
- encoding="utf-8",
- ) as f:
+ html_path = f"artifacts/test_splash_failure_html_{timestamp}.html"
+ with open(html_path, "w", encoding="utf-8") as f:
f.write(page.content())
raise
@@ -177,12 +198,15 @@ def on_page_error(exc: Any) -> None:
if cdp_session:
try:
- coverage = cdp_session.send("Profiler.takePreciseCoverage")["result"]
+ coverage_res = cdp_session.send("Profiler.takePreciseCoverage")
+ coverage = coverage_res["result"]
cdp_session.send("Profiler.stopPreciseCoverage")
cdp_session.send("Profiler.disable")
cdp_session.detach()
with open(
- "v8_coverage_splash_transition_flow_test.json", "w", encoding="utf-8"
+ "v8_coverage_splash_transition_flow_test.json",
+ "w",
+ encoding="utf-8",
) as f:
json.dump(coverage, f)
except Exception as cov_err:
From 08b0354fe16992a1370707b720abaef738ab465e Mon Sep 17 00:00:00 2001
From: "coderabbitai[bot]"
<136622811+coderabbitai[bot]@users.noreply.github.com>
Date: Sat, 15 Aug 2026 05:00:55 +0000
Subject: [PATCH 07/35] CodeRabbit Generated Unit Tests: Add Generated Unit
Tests for PR Changes
---
tests/splash_transition_flow_test.py | 431 +++++++++++++++++++++++++++
1 file changed, 431 insertions(+)
create mode 100644 tests/splash_transition_flow_test.py
diff --git a/tests/splash_transition_flow_test.py b/tests/splash_transition_flow_test.py
new file mode 100644
index 000000000..01982ea63
--- /dev/null
+++ b/tests/splash_transition_flow_test.py
@@ -0,0 +1,431 @@
+# Copyright (C) 2025-2026 Egor Kostan
+# SPDX-License-Identifier: GPL-3.0-or-later
+# tests/splash_transition_flow_test.py
+"""
+Splash Screen Transition & Telemetry Test Suite (Playwright + UI Automation)
+=============================================================================
+
+Overview
+--------
+Verifies the asynchronous web loading workflow, custom shell initialization pipeline,
+progressive assembly telemetry, and in-game progress transition mechanics. Eliminates
+race conditions by validating orderly handshakes between the DOM layout engine and the
+WebAssembly runtime graphics context.
+
+Prerequisites
+-------------
+- http://localhost:8080/index.html (HTML5 export with preloader & overlays)
+- pytest, playwright
+
+Running
+-------
+pytest -k splash_transition_flow -q
+
+Artifacts
+---------
+v8_coverage_splash_transition_flow_test.json, artifacts/test_splash_failure_*.png/txt/html
+"""
+
+import json
+import os
+import re
+import time
+from pathlib import Path
+from typing import Any
+
+from playwright.sync_api import Page, expect
+
+from tests.test_utils import DEFAULT_TIMEOUT, TEST_TIMEOUT
+
+
+# DO NOT REFACTOR: Must consume function-scoped `page` to capture preloader & startup telemetry.
+def test_splash_transition_flow(page: Page) -> None:
+ """
+ Validates assembly stream metrics, progressive telemetry monotonicity,
+ WebGL frame canvas presentation, and orderly removal of preloader DOM layers.
+ """
+ logs: list[dict[str, str]] = []
+ page_errors: list[str] = []
+ cdp_session = None
+
+ def on_console(msg: Any) -> None:
+ """Capture all console logs to track runtime lifecycle telemetry."""
+ logs.append({"type": msg.type, "text": msg.text})
+
+ def on_page_error(exc: Any) -> None:
+ """Capture uncaught runtime errors during engine boot."""
+ page_errors.append(f"Uncaught Exception: {exc.message}\n{exc.stack}")
+
+ # Register listeners BEFORE navigation to capture early boot telemetry & errors
+ page.on("console", on_console)
+ page.on("pageerror", on_page_error)
+
+ try:
+ # 1. INITIALIZE V8 PRECISE COVERAGE VIA CDP
+ cdp_session = page.context.new_cdp_session(page)
+ cdp_session.send("Profiler.enable")
+ cdp_session.send(
+ "Profiler.startPreciseCoverage", {"callCount": True, "detailed": True}
+ )
+
+ # 2. MONITOR INITIAL BROWSER LOADING LAYER
+ page.goto(
+ "http://localhost:8080/index.html",
+ wait_until="domcontentloaded",
+ timeout=DEFAULT_TIMEOUT,
+ )
+
+ # Verify custom HTML layout preloader maps instantly to the viewport
+ loading_overlay = page.locator("#loading")
+ expect(loading_overlay).to_be_visible(timeout=TEST_TIMEOUT)
+
+ # 3. VERIFY ENGINE INITIALIZATION & RUNTIME TELEMETRY
+ page.wait_for_function(
+ "() => window.godotInitialized === true", timeout=DEFAULT_TIMEOUT
+ )
+
+ # Parse progressive assembly transfer marks ("Telemetry - Assembly Transfer: X%")
+ progress_values: list[int] = []
+ for log in logs:
+ match = re.search(r"Telemetry - Assembly Transfer:\s*(\d+)%", log["text"])
+ if match:
+ progress_values.append(int(match.group(1)))
+
+ # Assert telemetry presence, range bounds, and monotonic forward progression
+ assert (
+ len(progress_values) > 0
+ ), "No 'Telemetry - Assembly Transfer:' marks captured during engine boot."
+ assert all(
+ 0 <= val <= 100 for val in progress_values
+ ), f"Telemetry percentage out of bounds [0, 100]: {progress_values}"
+ assert progress_values == sorted(
+ progress_values
+ ), f"Assembly transfer telemetry did not progress monotonically: {progress_values}"
+
+ # 4. ASSIGN RENDERING CANVAS HANDSHAKE & STRUCTURAL GEOMETRY
+ canvas_element = page.locator("#canvas")
+ expect(canvas_element).to_be_visible(timeout=TEST_TIMEOUT)
+
+ canvas_box = canvas_element.bounding_box()
+ assert canvas_box is not None, "Canvas element has no rendered bounding box"
+ assert (
+ canvas_box["width"] > 0
+ ), "Canvas rendered width is zero (viewport layout failure)"
+ assert (
+ canvas_box["height"] > 0
+ ), "Canvas rendered height is zero (viewport layout failure)"
+
+ assert (
+ "SkyLockAssault" in page.title()
+ ), f"Target application title mismatch: '{page.title()}'"
+
+ # 5. VERIFY DOM TEARDOWN & LIFECYCLE INVARIANTS
+ expect(loading_overlay).to_be_hidden(timeout=TEST_TIMEOUT)
+ assert page.evaluate(
+ "() => document.getElementById('loading').getAttribute('aria-hidden') === 'true'"
+ ), "Loading container missing aria-hidden='true' post-initialization"
+
+ # Invariant: engine initialization state must remain true after overlay teardown
+ assert page.evaluate(
+ "() => window.godotInitialized === true"
+ ), "window.godotInitialized lost its truthy state after splash transition completed"
+
+ # 6. AUDIT FATAL PARSING & SCRIPT COMPILATION EXCEPTIONS
+ critical_faults = [
+ log["text"]
+ for log in logs
+ if log["type"] == "error"
+ and not any(
+ phrase in log["text"].lower()
+ for phrase in ["encryption aborted", "salt is empty"]
+ )
+ ] + page_errors
+
+ assert (
+ len(critical_faults) == 0
+ ), f"Critical exceptions found during web handshake:\n" + "\n".join(
+ critical_faults
+ )
+
+ except Exception as e:
+ print(f"Test: 'test_splash_transition_flow' failed: {e!s}")
+ os.makedirs("artifacts", exist_ok=True)
+ timestamp: int = int(time.time())
+
+ # Isolate diagnostic files on execution crashes
+ page.screenshot(
+ path=f"artifacts/test_splash_failure_screenshot_{timestamp}.png"
+ )
+
+ with open(
+ f"artifacts/test_splash_failure_console_logs_{timestamp}.txt",
+ "w",
+ encoding="utf-8",
+ ) as f:
+ f.write("--- CONSOLE LOGS ---\n")
+ for log in logs:
+ f.write(f"[{log['type']}] {log['text']}\n")
+ f.write("\n--- PAGE ERRORS ---\n")
+ for p_err in page_errors:
+ f.write(f"{p_err}\n")
+
+ with open(
+ f"artifacts/test_splash_failure_html_{timestamp}.html",
+ "w",
+ encoding="utf-8",
+ ) as f:
+ f.write(page.content())
+ raise
+
+ finally:
+ try:
+ page.remove_listener("console", on_console)
+ page.remove_listener("pageerror", on_page_error)
+ except Exception:
+ pass
+
+ if cdp_session:
+ try:
+ coverage = cdp_session.send("Profiler.takePreciseCoverage")["result"]
+ cdp_session.send("Profiler.stopPreciseCoverage")
+ cdp_session.send("Profiler.disable")
+ cdp_session.detach()
+ with open(
+ "v8_coverage_splash_transition_flow_test.json",
+ "w",
+ encoding="utf-8",
+ ) as f:
+ json.dump(coverage, f)
+ except Exception as cov_err:
+ print(f"Warning: Failed to harvest V8 coverage data: {cov_err}")
+
+
+# ---------------------------------------------------------------------------
+# Unit tests for the `onProgress` telemetry callback introduced in
+# custom_shell.html. These tests extract the real callback source verbatim
+# (via brace-matching, not a hardcoded copy) and exercise it in an isolated
+# JS context, independent of the Godot WASM boot flow / dev server.
+# ---------------------------------------------------------------------------
+
+_CUSTOM_SHELL_PATH = Path(__file__).resolve().parents[1] / "custom_shell.html"
+_ON_PROGRESS_MARKER = "onProgress: function(current, total)"
+
+
+def _read_custom_shell_source() -> str:
+ """Reads the raw custom_shell.html source from the repository root."""
+ return _CUSTOM_SHELL_PATH.read_text(encoding="utf-8")
+
+
+def _extract_on_progress_function_source() -> str:
+ """Extracts the `onProgress` telemetry callback verbatim from custom_shell.html.
+
+ Uses brace counting (rather than a fixed-indentation regex) so extraction
+ keeps working even if the surrounding code is reformatted or re-indented.
+ """
+ html = _read_custom_shell_source()
+
+ try:
+ marker_idx = html.index(_ON_PROGRESS_MARKER)
+ except ValueError as exc:
+ raise AssertionError(
+ "onProgress telemetry handler not found in custom_shell.html; "
+ "source may have changed shape"
+ ) from exc
+
+ brace_start = html.index("{", marker_idx)
+ depth = 0
+ idx = brace_start
+ while idx < len(html):
+ if html[idx] == "{":
+ depth += 1
+ elif html[idx] == "}":
+ depth -= 1
+ if depth == 0:
+ break
+ idx += 1
+ else:
+ raise AssertionError(
+ "Could not find matching closing brace for onProgress function body"
+ )
+
+ body = html[brace_start : idx + 1]
+ return f"function(current, total) {body}"
+
+
+def _run_on_progress(page: Page, fn_source: str, calls: list[tuple[int, int]]) -> list[str]:
+ """Evaluates the extracted onProgress function against a series of
+ (current, total) calls and returns every console.log message it emitted.
+ """
+ return page.evaluate(
+ """([fnSource, calls]) => {
+ const onProgress = new Function('return (' + fnSource + ')')();
+ const outputs = [];
+ const originalLog = console.log;
+ console.log = (msg) => { outputs.push(msg); };
+ try {
+ for (const [current, total] of calls) {
+ onProgress(current, total);
+ }
+ } finally {
+ console.log = originalLog;
+ }
+ return outputs;
+ }""",
+ [fn_source, calls],
+ )
+
+
+def test_on_progress_telemetry_math_is_correct(page: Page) -> None:
+ """
+ Unit-tests the `onProgress` telemetry callback added to custom_shell.html
+ in isolation, locking down its percentage math independently of the full
+ Godot WASM boot flow exercised by `test_splash_transition_flow`.
+ """
+ fn_source = _extract_on_progress_function_source()
+
+ outputs = _run_on_progress(
+ page, fn_source, [(0, 200), (50, 200), (100, 200), (200, 200)]
+ )
+
+ assert outputs == [
+ "Telemetry - Assembly Transfer: 0%",
+ "Telemetry - Assembly Transfer: 25%",
+ "Telemetry - Assembly Transfer: 50%",
+ "Telemetry - Assembly Transfer: 100%",
+ ]
+
+
+def test_on_progress_floors_fractional_percentages(page: Page) -> None:
+ """Regression test: fractional percentages must be floored, not rounded."""
+ fn_source = _extract_on_progress_function_source()
+
+ outputs = _run_on_progress(
+ page,
+ fn_source,
+ [
+ (1, 3), # 33.33...% -> must floor to 33%, not round to 33% or 34%
+ (2, 3), # 66.66...% -> must floor to 66%, not round to 67%
+ (99, 100), # 99% exactly
+ ],
+ )
+
+ assert outputs == [
+ "Telemetry - Assembly Transfer: 33%",
+ "Telemetry - Assembly Transfer: 66%",
+ "Telemetry - Assembly Transfer: 99%",
+ ]
+
+
+def test_on_progress_skips_logging_when_total_is_zero(page: Page) -> None:
+ """
+ Edge case: onProgress must not emit any telemetry (or divide by zero,
+ producing NaN/Infinity) when `total` is 0. This guards the
+ `if (total > 0)` check in the callback.
+ """
+ fn_source = _extract_on_progress_function_source()
+
+ outputs = _run_on_progress(page, fn_source, [(0, 0), (5, 0)])
+
+ assert outputs == [], f"Expected no telemetry logs when total is 0, got: {outputs}"
+
+
+def test_on_progress_message_format_matches_expected_pattern(page: Page) -> None:
+ """
+ Regression test: the emitted telemetry text must match the exact
+ "Telemetry - Assembly Transfer: