Skip to content

Commit 3457cba

Browse files
authored
[12.x] remove @return docblocks on constructors (#55076)
* remove `@return` docblocks on constructors PHP constructors don't really return anything, so the docblock is kind of unnecessary. this also brings consistency since we have some that use the tag and some that do not. we have a total of 557 constructors in the framework, so we definitely used it more than we didn't, but my personal opinion is this direction makes more sense. https://docs.phpdoc.org/guide/references/phpdoc/tags/return.html#return laravel/framework#702 https://www.php.net/manual/en/language.oop5.decon.php * minor formatting * minor formatting
1 parent 90cab66 commit 3457cba

8 files changed

+0
-8
lines changed

Connections/PhpRedisConnection.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ class PhpRedisConnection extends Connection implements ConnectionContract
3535
* @param \Redis $client
3636
* @param callable|null $connector
3737
* @param array $config
38-
* @return void
3938
*/
4039
public function __construct($client, ?callable $connector = null, array $config = [])
4140
{

Connections/PredisConnection.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ class PredisConnection extends Connection implements ConnectionContract
2323
* Create a new Predis connection.
2424
*
2525
* @param \Predis\Client $client
26-
* @return void
2726
*/
2827
public function __construct($client)
2928
{

Events/CommandExecuted.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ class CommandExecuted
4646
* @param array $parameters
4747
* @param float|null $time
4848
* @param \Illuminate\Redis\Connections\Connection $connection
49-
* @return void
5049
*/
5150
public function __construct($command, $parameters, $time, $connection)
5251
{

Limiters/ConcurrencyLimiter.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ class ConcurrencyLimiter
4444
* @param string $name
4545
* @param int $maxLocks
4646
* @param int $releaseAfter
47-
* @return void
4847
*/
4948
public function __construct($redis, $name, $maxLocks, $releaseAfter)
5049
{

Limiters/ConcurrencyLimiterBuilder.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,6 @@ class ConcurrencyLimiterBuilder
5656
*
5757
* @param \Illuminate\Redis\Connections\Connection $connection
5858
* @param string $name
59-
* @return void
6059
*/
6160
public function __construct($connection, $name)
6261
{

Limiters/DurationLimiter.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,6 @@ class DurationLimiter
5656
* @param string $name
5757
* @param int $maxLocks
5858
* @param int $decay
59-
* @return void
6059
*/
6160
public function __construct($redis, $name, $maxLocks, $decay)
6261
{

Limiters/DurationLimiterBuilder.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,6 @@ class DurationLimiterBuilder
5656
*
5757
* @param \Illuminate\Redis\Connections\Connection $connection
5858
* @param string $name
59-
* @return void
6059
*/
6160
public function __construct($connection, $name)
6261
{

RedisManager.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,6 @@ class RedisManager implements Factory
6464
* @param \Illuminate\Contracts\Foundation\Application $app
6565
* @param string $driver
6666
* @param array $config
67-
* @return void
6867
*/
6968
public function __construct($app, $driver, array $config)
7069
{

0 commit comments

Comments
 (0)