fix(web): avoid local preview state in pinned browsers

Author: IM.codes

web/src/components/FileBrowser.tsx

@@ -667,6 +667,10 @@ export function FileBrowser({
     if (editDirtyRef.current) {
       if (!window.confirm(t('fileBrowser.unsavedChanges'))) return;
     }
+    if (onPreviewFile) {
+      onPreviewFile({ path: filePath, preferDiff, preview: { status: 'loading', path: filePath } });
+      return;
+    }
     dismissedAutoPreviewPathRef.current = null;
     setEditDirty(false);
     setEditContent('');
@@ -675,10 +679,6 @@ export function FileBrowser({
     const loadingPreview: FileBrowserPreviewState = { status: 'loading', path: filePath };
     setPreview(loadingPreview);
     setShowDiff(preferDiff);
-    if (onPreviewFile) {
-      onPreviewFile({ path: filePath, preferDiff, preview: loadingPreview });
-      return;
-    }
     const requestId = ws.fsReadFile(filePath);
     pendingReadRef.current.set(requestId, filePath);
     const diffId = ws.fsGitDiff(filePath);
@@ -948,8 +948,8 @@ export function FileBrowser({
 
   const alreadySet = new Set(alreadyInserted);
   const usesExternalPreview = !!onPreviewFile;
-  const hasPreview = mode !== 'dir-only' && preview.status !== 'idle';
-  const hasInlinePreview = hasPreview && !usesExternalPreview;
+  const hasInlinePreview = mode !== 'dir-only' && preview.status !== 'idle' && !usesExternalPreview;
+  const hasPreview = hasInlinePreview;
 
   const previewPath = preview.status !== 'idle' ? (preview as { path: string }).path : null;
 

web/test/components/FileBrowser.test.tsx

@@ -824,6 +824,38 @@ describe('FileBrowser', () => {
     expect(onPreviewFile).toHaveBeenCalled();
     expect(document.querySelector('.fb-preview')).toBeNull();
     expect(document.querySelector('.fb-body-split')).toBeNull();
+    expect(document.querySelector('.fb-tree-split')).toBeNull();
+    expect(document.querySelector('.fb-resize-handle')).toBeNull();
+  });
+
+  it('does not change the source panel layout when opening external previews from the files list', async () => {
+    const { ws, respond } = makeWsFactory();
+    const onPreviewFile = vi.fn();
+    render(
+      <FileBrowser
+        ws={ws}
+        mode="file-single"
+        layout="panel"
+        initialPath="/home/user"
+        onPreviewFile={onPreviewFile}
+        onConfirm={vi.fn()}
+      />,
+    );
+
+    await act(async () => { respond([{ name: 'foo.ts', isDir: false }], '/home/user'); });
+
+    const fileEntry = await screen.findByText('foo.ts');
+    await act(async () => { fireEvent.click(fileEntry); });
+
+    expect(onPreviewFile).toHaveBeenCalledWith({
+      path: '/home/user/foo.ts',
+      preferDiff: false,
+      preview: { status: 'loading', path: '/home/user/foo.ts' },
+    });
+    expect(document.querySelector('.fb-preview')).toBeNull();
+    expect(document.querySelector('.fb-body-split')).toBeNull();
+    expect(document.querySelector('.fb-tree-split')).toBeNull();
+    expect(document.querySelector('.fb-resize-handle')).toBeNull();
   });
 
   it('hides the embedded changes section in files view when an external preview host is provided', async () => {