Add tests for encoders #25
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests for encoders along with a few improvements and fixes.
The tests are reference tests similar to the existing ones. Basically, the encoder is given a dyn image and is asked to encode it. We then save the encoded image to disk and commit it. Additionally, the encoded image is then opened to verify that it is valid and saved as PNG to show the output (in case pixel data changed). PNGs are git-ignored.
Similar to #17, files are only written to disk if the
BLESSenv var is set.Other changes:
WbmpEncoderignoring threshold.OtbEncoderandWbmpEncoder. This is now consistent with all encoders inimage.*Encoder::newnow returnsSelfinstead of anImageResult<Self>that is alwaysOkfor all encoders. This is now consistent with all encoders inimage.