DynamicImage::crop() is slow because to_image() is slow

[Shnatsel]

In v0.25.2, the crop operation is implemented as:

image/src/dynimage.rs

Line 422 in e176cd4

dynamic_map!(*self, ref mut p => imageops::crop(p, x, y, width, height).to_image())

which obtains a view into an image, and then calls to_image() on it to turn it into a new image buffer. And to_image() shuffles pixels one by one in a purely scalar fashion and with bounds checks on every pixel:

image/src/image.rs

Lines 1131 to 1136 in e176cd4

	for y in 0..self.inner.ystride {
	for x in 0..self.inner.xstride {
	let p = borrowed.get_pixel(x + self.inner.xoffset, y + self.inner.yoffset);
	out.put_pixel(x, y, p);
	}
	}

A much better way would be iterating over the rows, and copying over entire rows with slice::copy_from_slice(). That would both leverage vector instructions and reduce the amount of bounds checks from n^2 to n.

[jamninetyfive]

same here. do a PR?