General improvements and fixes following the switch to .yaml based input

[davidrudlstorfer]

From #354 and #135 (and other issues) some open ToDo's emerged which are summarized in the following:

High Priority

• Readd cubitpy support Activate CubitPy support again #349

• Fix documentation pipeline Fix docu pipeline following #354 #357

• Fix testsuite (somehow the last nightly pipeline failed https://github.com/imcs-compsim/meshpy/actions/runs/15291400842/job/43051162413 I have no clue why because it pulls an old version of MeshPy. Maybe some cache is invalid. Let's see if it works tomorrow) => solved itself

• Fix xml writeout Fix writing of NOX xml #360

Testing infrastructure

• improve testing infrastructure (test abaqus input files also with compare_nested_list_or_dicts, remove entire string comparison from our side, also open a diff in VSCode for the yaml files)

• Check & increase minimum testing coverage Increase minimum coverage #362

Code quality

• Replace self.element_description with self.data. Cleanup NURBS patch #372

• Pass the connectivity array of elements into the input file and hand over the conversion for a MeshPy Node to the FourCIPP converter Add more converters to input files #370

• move all dump_to_list logic to the input file (similar to boundary_condition, function, etc…)

• move element_type_to_four_c_string to a more central place, i.e., out of core. This should be easily possible once the dump_to_list functions are in the input file (currently a circular import restricts me from moving this)

• then we can also fix the current hackery in the solidrigidsphere for free (here also a circular import hinders me from working further on this)

• Finally we can improve and simplify (by a lot) the model importer

• And finally, finally we can improve and simplify the mesh to dict conversion (by a lot)

Miscellaneous

• Improve performance again Compare performance dat vs yaml #358, Improve performance of rotation copy #363, Improve performance by disabling converter during dumping #364, Use rapidyaml to dump yaml files 4C-multiphysics/fourcipp#59

• discuss if the validation should be turned on during dump (note: this could lead to failing tests, i.e., some form of input changes in 4C - we pull the latest FourCIPP version nightly - then the validation would fail, note that this could also be a good thing) Change default to enable input file validation by FourCIPP #361

• Update fourcipp to be pulled from pip once it is published to pip

Reference files

• Convert remaining input files to full precision (from Store reference files in full double precision #309)

  List of files

  • 4C_input_solid_cuboid.4C.yaml
  • test_create_cubit_input_block.4C.yaml
  • test_create_cubit_input_solid_shell_blocks.4C.yaml
  • test_create_cubit_input_solid_shell_dome.4C.yaml
  • test_create_cubit_input_tube.4C.yaml
  • test_four_c_beam_to_solid.4C.yaml
  • test_four_c_import_non_consecutive_geometry_sets_input.4C.yaml
  • test_four_c_simulation_dbc_monitor_to_input_restart.4C.yaml
  • test_four_c_simulation_dirichlet_boundary_to_neumann_boundary_with_all_values_neumann.4C.yaml
  • test_four_c_simulation_honeycomb_sphere_import.4C.yaml
  • test_meshpy_comments_in_solid_initial.4C.yaml
  • test_meshpy_fluid_element_section_import.4C.yaml
  • test_meshpy_nurbs_import_solid_mesh.4C.yaml
  • test_meshpy_surface_to_surface_contact_import_solid_mesh.4C.yaml
  • test_meshpy_vtk_writer_solid_elements_import.4C.yaml
  • test_tutorial.4C.yaml

• Store reference files in ordered fashion (from Store yaml reference files in ordered fashion #308)
  Export the .4C.yaml files in ordered fashion to be able to easier compare them. Think about adding an option to FourCIPP to allow one to specify the order in which to dump everything, i.e., title at first, elements/nodes at the end, the rest in alphabetical fashion

[davidrudlstorfer]

@isteinbrecher the ToDo's of this issue are getting fewer and fewer and in my opinion the code quality rises :)

One requst:

Could you look into

• Replace self.element_description with self.data.

I already gave this a try but I am unsure on what your initial idea was. The self.element_description is now only appearing in the Nurbs elements - and I have no clue of them 😅 if we discuss the approach together I would also be happy to tackle this (but I think it takes you longer to explain it to me than to change the few lines 🫣)

Once this is done I would tackle

• move all dump_to_list logic to the input file (similar to boundary_condition, function, etc…)

• move element_type_to_four_c_string to a more central place, i.e., out of core. This should be easily possible once the dump_to_list functions are in the input file (currently a circular import restricts me from moving this)

• then we can also fix the current hackery in the solidrigidsphere for free (here also a circular import hinders me from working further on this)

as they are closely related and connected. I think it would make sense that we briefly discuss our ideas regarding the central "dump" logic to prevent that I "code into the wrong direction".

[isteinbrecher]

Thanks for the overview!

#372 should take care of the self.element_description.

Yes, let's discuss the next steps, I will have to think a little bit about that too.