Remove inheritance of InputFile on Mesh #321
Conversation
| mesh_1 = InputFile() | ||
| mesh_1 = Mesh() | ||
| create_test_mesh(mesh_1) | ||
|
|
||
| mesh_2 = InputFile() | ||
| mesh_2 = Mesh() | ||
| create_test_mesh(mesh_2) |
There was a problem hiding this comment.
@isteinbrecher one general question I wanted to discuss before proceeding to adjust the tests
In my opinion, in the future MeshPy should work without fourcipp, i.e., a 4C input file. For that it would be ideal if we could run tests on Meshes.
Currently we are not able to compare meshes within the testing framework. Do you share this opinion that we should test it without any overhead?
Maybe you have additional ideas, etc.
There was a problem hiding this comment.
If we share this opinion I would add an option that we can compare individual Meshes in our testing suite.
This somehow contradicts our discussion we had yesterday - we said we mainly wanted to focus on tests with reference files.
But in my opinion it's not that nice that we will always depend on fourcipp.
Maybe create a really generic input file which just dumps the raw data to yaml/json files and compare these?
| @@ -102,7 +102,7 @@ def _get_yaml_geometry_sets( | |||
| return geometry_sets_in_this_section | |||
|
|
|||
|
|
|||
| class InputFile(_Mesh): | |||
| class InputFile: | |||
There was a problem hiding this comment.
And as a final note: I tested the overall working with my minimal example from #318 and everything worked out of the box as we discussed it.
I decided to add one additional step before moving the input file to fourcipp - namely the removal of the inheritance of the
InputFileonMeshThe overall code changes are pretty minimal - but major changes must occur to the testing framework.
Following this PR - the change to
fourcippshould be really straight forward