Split mesh creation function #329
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ry to beam_line, beam_arc and beam_helix
…ry to beam_line, beam_arc and beam_helix setup pre-commit setup pre-commit modified examples folder Clean notebook metadata using nbstripout revert example folder
There was a problem hiding this comment.
@gnath-aswin thanks for your first contribution!
This PR is already looking really good. I have a few points for discussion:
-
I think we can remove the deprecation stage and just switch to the new layout. MeshPy only has a very small number of active users/developers and, therefore, we can simply switch.
-
Should we directly update the docstrings in the touched files to align with our new style?
-
Should we directly split up the tests to reflect the src code files?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Organize
src/meshpy/mesh_creation_functionsFolderThis PR addresses issue #319 of organizing the
src/meshpy/mesh_creation_functionsfolder.Changes Made
Moved all application-style beam mesh modules to
mesh_creation_functions/applications:beam_stent.pybeam_honeycomb.pybeam_fibers_in_rectangle.pybeam_wire.pySplit basic functionalities from
beam_basic_geometry.pyinto new modules:beam_line.py:Contains
create_beam_mesh_lineandcreate_beam_mesh_line_continuationbeam_arc.py:Contains
create_beam_mesh_arc_segment_via_rotation,create_beam_mesh_arc_segment_via_axis,create_beam_mesh_arc_segment_2d, andcreate_beam_mesh_arc_at_nodebeam_helix.py: containscreate_beam_mesh_helixLeft
beam_basic_geometry.pywith a deprecation warning:Renamed modules for clarity:
beam_curve.py→beam_parametric_curve.pybeam_nurbs.py→beam_from_nurbs_curve.py