Skip to content

Fix writing of NOX xml #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2025
Merged

Conversation

isteinbrecher
Copy link
Collaborator

This PR fixes the currently failing writing of NOX xml files and adds a test case.

Closes #353

Copy link
Collaborator

@davidrudlstorfer davidrudlstorfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice that we now test the xml file creation. Thanks for adding this @isteinbrecher :)

Only a few very minor comments/questions

Copy link
Collaborator

@davidrudlstorfer davidrudlstorfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isteinbrecher sorry for my confusion regarding the pytest parametrization - I mixed up the variable assignements.

Thanks for the changes and let's get this merged:) 🚀

@isteinbrecher isteinbrecher merged commit 37d0b35 into imcs-compsim:main Jun 4, 2025
9 of 10 checks passed
@isteinbrecher isteinbrecher deleted the fix-nox-xml branch June 4, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XML functionality of input file does not work / is not tested
3 participants