Fix writing of NOX xml #360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isteinbrecher
commented
May 30, 2025
isteinbrecher
force-pushed
the
fix-nox-xml
branch
from
a9e7d1e to
7d19643
Compare
There was a problem hiding this comment.
Really nice that we now test the xml file creation. Thanks for adding this @isteinbrecher :)
Only a few very minor comments/questions
34 tasks
isteinbrecher
force-pushed
the
fix-nox-xml
branch
from
7d19643 to
cf694dc
Compare
davidrudlstorfer
approved these changes
Jun 2, 2025
There was a problem hiding this comment.
@isteinbrecher sorry for my confusion regarding the pytest parametrization - I mixed up the variable assignements.
Thanks for the changes and let's get this merged:) 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the currently failing writing of NOX xml files and adds a test case.
Closes #353