Skip to content

Unify numerical comparison across testing framework #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

davidrudlstorfer
Copy link
Collaborator

Closes #184

@davidrudlstorfer
Copy link
Collaborator Author

  1. The cosserat tests are currently failing because the global tolerance is too tight. Should we redo the results?

  2. With the current changes I introduced the numerical comparison into the test framework. Should we instead introduce it into the general MeshPy utils and also use it in MeshPy?

  3. Should we globally "reconfigure" the tolerances? my.eps?

@davidrudlstorfer davidrudlstorfer force-pushed the unified_numerical_comparison branch from ae46fc0 to 0c08a51 Compare June 24, 2025 11:09
@davidrudlstorfer
Copy link
Collaborator Author

Looks like the cosserat tests were created on macOS because there they succeed :D

Copy link
Collaborator

@isteinbrecher isteinbrecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like how this improves the testing comparisons. (Actually quire strange what constructs could be found here 😂)

Comment on lines +54 to +55
rtol: float = 1e-13,
atol: float = 1e-13,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use the same global tolerances as introduced in #382?

@isteinbrecher
Copy link
Collaborator

  • The cosserat tests are currently failing because the global tolerance is too tight. Should we redo the results?

What exactly do you mean with "redo the results"?

  • With the current changes I introduced the numerical comparison into the test framework. Should we instead introduce it into the general MeshPy utils and also use it in MeshPy?

Without thinking to long about that, I would say yes, that would be a nice follow up.

  • Should we globally "reconfigure" the tolerances? my.eps?

You mean to unify them or lower the tolerances?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify numerical comparisons of arrays
2 participants