Skip to content

Commit d35871f

Browse files
committed
Updated downstream libraries, go version, and other tlc
1 parent 733f2e2 commit d35871f

File tree

7 files changed

+12
-14
lines changed

7 files changed

+12
-14
lines changed

.golangci.yml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,6 @@ linters-settings:
3030
sizeThreshold: 512
3131
gocyclo:
3232
min-complexity: 16
33-
golint:
34-
min-confidence: 0
35-
govet:
36-
check-shadowing: false
3733
lll:
3834
line-length: 300
3935
misspell:
@@ -57,9 +53,7 @@ linters:
5753
- dupl
5854
- durationcheck
5955
- errcheck
60-
- execinquery
6156
- exhaustive
62-
- exportloopref
6357
- gocritic
6458
- godot
6559
- gofmt

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
44
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
55
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
66

7+
## [0.7.1] - 2025-01-13
8+
### Changed
9+
- Updated downstream libraries, go version, etc
10+
711
## [0.7.0] - 2024-01-31
812
### Changed
913
- Instead of querying for the node architecture and os when inspecting pods, which rarely worked, use `platforms` on the config to determine which platforms should be required when checking upstream.

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# Build the manager binary
2-
FROM --platform=$BUILDPLATFORM golang:1.22 as builder
2+
FROM --platform=$BUILDPLATFORM golang:1.23 as builder
33

44
WORKDIR /workspace
55
# Copy the Go Modules manifests

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ HELM_DIR ?= deploy/charts/harbor-container-webhook
2323

2424
OUTPUT_DIR ?= bin
2525

26-
RUN_GOLANGCI_LINT := go run github.com/golangci/golangci-lint/cmd/golangci-lint@v1.55.2
26+
RUN_GOLANGCI_LINT := go run github.com/golangci/golangci-lint/cmd/golangci-lint@v1.63.4
2727

2828
# check if there are any existing `git tag` values
2929
ifeq ($(shell git tag),)

deploy/charts/harbor-container-webhook/Chart.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@ apiVersion: v2
22
name: harbor-container-webhook
33
description: Webhook to configure pods with harbor proxy cache projects
44
type: application
5-
version: 0.7.0
6-
appVersion: "0.7.0"
5+
version: 0.7.1
6+
appVersion: "0.7.1"
77
kubeVersion: ">= 1.16.0-0"
88
home: https://github.com/IndeedEng-alpha/harbor-container-webhook
99
maintainers:

internal/config/config.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ func detectNamespace() string {
3636

3737
// Fall back to the namespace associated with the service account token, if available
3838
if data, err := os.ReadFile("/var/run/secrets/kubernetes.io/serviceaccount/namespace"); err == nil {
39-
if ns := strings.TrimSpace(string(data)); len(ns) > 0 {
39+
if ns := strings.TrimSpace(string(data)); ns != "" {
4040
return ns
4141
}
4242
}

internal/webhook/manifest.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package webhook
22

3-
// slimManifest is a partial representation of the oci manifest to access the mediaType
3+
// slimManifest is a partial representation of the oci manifest to access the mediaType.
44
type slimManifest struct {
55
MediaType string `json:"mediaType"`
66
}
@@ -10,13 +10,13 @@ type platform struct {
1010
OS string `json:"os"`
1111
}
1212

13-
// indexManifest is a partial representation of the sub manifest present in a manifest list
13+
// indexManifest is a partial representation of the sub manifest present in a manifest list.
1414
type indexManifest struct {
1515
MediaType string `json:"mediaType"`
1616
Platform platform `json:"platform"`
1717
}
1818

19-
// slimManifestList is a partial representation of the oci manifest list to access the supported architectures
19+
// slimManifestList is a partial representation of the oci manifest list to access the supported architectures.
2020
type slimManifestList struct {
2121
MediaType string `json:"mediaType"`
2222
Manifests []indexManifest `json:"manifests"`

0 commit comments

Comments
 (0)