New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] allow none type for internal channel prefix #77

Open

longquanzheng opened this issue Feb 20, 2025 · 2 comments

Contributor

longquanzheng commented Feb 20, 2025

iwf-python-sdk/iwf/type_store.py

Line 52 in efb2583

if first is None:

this wont work for this case

Contributor Author

longquanzheng commented Feb 20, 2025

looks like it can be worked around type(None)

Contributor Author

longquanzheng commented Mar 13, 2025

but It's still better to fix this . because it's simpler, and currently working for
https://github.com/search?q=repo%3Aindeedeng%2Fiwf-python-sdk%20%22WorkflowState%5BNone%22&type=code

So we should keep it consistent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment