Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Each Integration Test should close their workflows when finished #537

Closed
samuel27m opened this issue Jan 29, 2025 · 0 comments · Fixed by #540
Closed

Each Integration Test should close their workflows when finished #537

samuel27m opened this issue Jan 29, 2025 · 0 comments · Fixed by #540

Comments

@samuel27m
Copy link
Member

samuel27m commented Jan 29, 2025

As part of our Integration Test suite, there are a lot of tests, and all of them create 1 workflow or more, runs assertions, and marks the test as passed.

This has lead to situations where workflows are left open, and then they are trying to interact with another tests worker, which fails the tests. E.g.:

Test1 starts the worker and service
Kicks off 2 workflows
2nd doesn't start, cool, move on, that's what we wanted to test
close the worker and service
workflow might still be running, waiting for workers

Test2 starts the worker and service
Runs its workflow
Waits for a while (for the timeout to happen) inTest2 workflow
The running workflow from Test1 finds a worker running, and kicks off requests
test fails because it didn't expect the call from the other workflow

The solution here is to ensure that each Integration Test closes the workflows it created before finishing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant