Skip to content

Tagpass with a list doesn't trigger error and just matches everything #16398

@knollet

Description

@knollet

Use Case

People work sloppily and try to match metrics with a tagpass = ["mymarkertag"] when the correct version would be tagpass = { "markertag" = ["mymarkertag"] } or similar.
Telegraf doesn't error out, though, and processors and outputs still process and put out the affected metrics because no working tagpass means matching every metric.

But it also matches metrics it shouldn't match and those end up in databases where they shouldn't end up.

Expected behavior

Error out with a config syntax error because tagpass expects a dictionary

Actual behavior

No erroring out and just matching everything leading to metrics in places where they don't belong.

Additional info

No response

Metadata

Metadata

Assignees

Labels

feature requestRequests for new plugin and for new features to existing plugins

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions