Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICQ responses do not seem to be not transmitted #4290

Open
5 tasks
danieljdd opened this issue Jan 22, 2025 · 3 comments
Open
5 tasks

ICQ responses do not seem to be not transmitted #4290

danieljdd opened this issue Jan 22, 2025 · 3 comments

Comments

@danieljdd
Copy link

Summary of Bug

It seems that ICQ for consumer chains is not functioning correctly in Hermes version 1.10.4. Currently, the related test is also disabled in the Hermes repository:

Reference to the test in the Hermes repo

We are running Cosmos SDK v0.50.9 and connecting with PSS to a local Gaia v27 node. In this setup, IBC and ICA are working correctly. However, while ICQ messages are being created by our chain, the MsgSubmitQueryResponse (stride.interchainquery.v1.MsgSubmitQueryResponse) does not seem to be sent by the relayer or is not being received properly.

In our previous setup with Cosmos SDK v0.47 as a standalone chain, this functionality was working as expected. It appears there is an issue with message transmission in the current configuration.

Version

Cosmos SDK: v0.50.9
Gaia: v27
Hermes version: 1.10.4

Steps to Reproduce

I expect by running below test the issue could be reproduced:
https://github.com/informalsystems/hermes/blob/be0be09d930f337de1f277e6eec65826a3a5ea2a/.github/workflows/integration.yaml#L221C1-L221C33.

Acceptance Criteria

Test runs as expected


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Hermes Jan 22, 2025
@ljoss17
Copy link
Contributor

ljoss17 commented Jan 24, 2025

Hi @danieljdd would you be able to share the error logs you are seeing when trying to relay CCQs?
Regarding the Hermes tests, these were disabled due to a potential misconfiguration which is causing a proof verification error when relaying the ICQ response. After investigating with the Hub and Stride teams it seems this issue was only present in Hermes test.

You mention the MsgSubmitQueryResponse is not being sent, are you using the exact proto files from Stride? Could you try running with log level trace if you aren't seeing any logs related to cross_chain_query

@danieljdd
Copy link
Author

Thank you for your reply and for sharing the context about the Hermes tests being disabled. It's good to hear that you've already investigated this!

Regarding your questions:

  1. Logs: When running Hermes with log level trace, we still do not see any logs related to cross_chain_query.

  2. Implementation Details:

    • We set the query and log it as follows:
      k.interchainQueryKeeper.SetQuery(ctx, query)
      logger.Debug("interchain query submitted", "ICQ ID", id)
      This produces the log:
      dockernet-into1-1 | 1:56PM DBG interchain query submitted ICQ ID="\x14:2:0" module=x/intent
      
    • For our Cosmos SDK v0.50+ setup, we included these options in the proto files, resulting in slightly different file descriptors:
      option (cosmos.msg.v1.signer) = "from_address";
      option (amino.name)           = "interchainquery/MsgSubmitQueryResponse";
    • We also tested with the exact proto files from Stride (v0.47). Unfortunately, this also did not generate any logs related to cross_chain_query. However, I suspect that above additional proto file options might be required for messages to be submitted properly in Cosmos SDK v0.50+.

Could Hermes be depending on the exact proto files (specifically the file descriptors) from Stride, which do not include these options and are still based on v0.47? Would be great it if you could confirm whether Hermes requires these exact file descriptors or if adjustments would be needed to support Cosmos SDK v0.50+ configurations.

@danieljdd
Copy link
Author

@ljoss17 curious if you have any updates on this issue. Since I couldn't find any logs related to cross_chain_query in debug mode, I’m wondering what that might indicate?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🩹 Triage
Development

No branches or pull requests

2 participants