feat: adds support for millisecond slot timepoints #94
+10
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
prestwich
requested changes
Nov 25, 2025
| /// The current number of milliseconds into the slot. | ||
| pub fn current_point_within_slot_ms(&self) -> Option<u64> { | ||
| let now = chrono::Utc::now(); | ||
| let timestamp = now.timestamp() as u64; |
Member
There was a problem hiding this comment.
prestwich
reviewed
Nov 25, 2025
| let millis = now.timestamp_subsec_millis() as u64; | ||
|
|
||
| self.point_within_slot(timestamp) | ||
| .map(|point| std::time::Duration::from_secs(point).as_millis() as u64 + millis) |
Member
There was a problem hiding this comment.
rather than operating on seconds, and then converting to ms and adding, just do math on the u64s
add
fn point_within_slot_ms
fn slot_utc_offset_ms
etc.
do not concert to Duration as that may mess up the math
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: adds support for millisecond slot timepoints