feat: implement transaction validation UTxO rule for Shelley Era
#429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tx-validator-phase1
…tx-validator-phase1
…tx-validator-phase1
…d test cases for validate ttl function with invalid transaction cbor
…tion phase1 module
golddydev
requested review from
SupernaviX,
lowhung and
whankinsiv
and removed request for
whankinsiv
Collaborator
|
Would it be possible to break this PR up into smaller pieces? I don't know if I have the context window to review 41 files and 2k line changes 😓 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements transaction phase 1 validation rule:
UTxOrule forShelleyEra.And integrate this validation into
tx_unpackermodule and validate transactions for onlyShelleyera.Related Issue(s)
Related to #329
How was this tested?
UTxOrulecargo test --package acropolis_module_tx_unpacker --lib -- validations::shelley::utxo::tests::shelley_test --nocaptureIntegrate validation to
omnibusprocess, and every transaction from mithril snapshot passed.Checklist
Impact / Side effects
This may affect the
tx_unpackermodule and itsdownstreammodules, because we dovalidatetransactions before applying and publishing messages.Reviewer notes / Areas to focus
tx_unpacker/validations/shelley/utxo.rsValueNotConservedUTxO,UpdateFailurerules will be implemented by following PRs.OutputBootAddrAttrsTooBig: For now, we only store raw payload for byron address, should we decode all byron addresses and validate this rule?