Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Onboarding - Keychain created and link wallet info screens - no confirmation modal on close #2004

Open
2 tasks done
oldGreg5 opened this issue Mar 11, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@oldGreg5
Copy link
Contributor

oldGreg5 commented Mar 11, 2025

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Onboarding - Keychain created and link wallet info screens - no confirmation modal on close is shown.
Onboarding is closed and user is back on Discovery page.

Keychain created screen:
Image

Link wallet info screen:
Image

Expected Behavior

  1. On keychain created screen and link wallet info screen when user clicks close button, then we should show confirmation dialog with confirm and cancel buttons.

Figma design here

  1. Once this dialog is set for both screens please apply it to select wallet screen as well as it has wrong content now:

Image

Project

Frontend

What operating system are you seeing the problem on?

macOS

What browsers are you seeing the problem on?

Chrome

Relevant log output

Anything else?

Note for testers:

  1. I added some missing tests and marked them as skipped(with this issue number tagged) until this is done. Make sure they pass and unblock them.
  2. Please add missing tests in Onboarding suite after keychain created success step. Add checking modal content for all the steps that display it (content changes after keychain create success step so it mentions 'link wallet' being incomplete)

Code of Conduct

  • I agree to follow this project's Code of Conduct
@oldGreg5 oldGreg5 added the bug Something isn't working label Mar 11, 2025
@oldGreg5 oldGreg5 changed the title [Bug]: Onboarding - Keychain created screen - no confirmation modal on close [Bug]: Onboarding - Keychain created and link wallet info screens - no confirmation modal on close Mar 11, 2025
@minikin minikin moved this from New to 📋 Backlog in Catalyst Mar 12, 2025
@minikin minikin added this to the Fund14 Technical Readiness milestone Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants