format: lint

Signed-off-by: Roni Friedman-Melamed <[email protected]>

Author: Roni-Friedman

src/instructlab/eval/unitxt.py

@@ -43,25 +43,25 @@ def __init__(
         model_path,
         unitxt_recipe: str,
     ):
-        task = self.assign_task_name()
-        tasks_dir = self.assign_tasks_dir(task)
+        unitxt_task = self.assign_task_name()
+        tasks_dir = self.assign_tasks_dir(unitxt_task)
         super().__init__(
-            model_path=model_path, tasks_dir=tasks_dir, tasks=[task], few_shots=0
+            model_path=model_path, tasks_dir=tasks_dir, tasks=[unitxt_task], few_shots=0
         )
         self.unitxt_recipe = unitxt_recipe
 
-    def assign_tasks_dir(self, task):
-        return f"{TEMP_DIR_PREFIX}_{task}"
+    def assign_tasks_dir(self, task_name):
+        return f"{TEMP_DIR_PREFIX}_{task_name}"
 
     def assign_task_name(self):
         return str(uuid4())
 
-    def prepare_unitxt_files(self) -> tuple:
-        task = self.tasks[0]
-        yaml_file = os.path.join(self.tasks_dir, f"{task}.yaml")
+    def prepare_unitxt_files(self) -> None:
+        taskname = self.tasks[0]
+        yaml_file = os.path.join(str(self.tasks_dir), f"{taskname}.yaml")
         create_unitxt_pointer(self.tasks_dir)
         create_unitxt_yaml(
-            yaml_file=yaml_file, unitxt_recipe=self.unitxt_recipe, task_name=task
+            yaml_file=yaml_file, unitxt_recipe=self.unitxt_recipe, task_name=taskname
         )
 
     def remove_unitxt_files(self):
@@ -71,7 +71,7 @@ def remove_unitxt_files(self):
             shutil.rmtree(self.tasks_dir)
         else:
             logger.warning(
-                f"unitxt tasks dir did not start with '{TEMP_DIR_PREFIX}' and therefor was not deleted"
+                "unitxt tasks dir did not start with '%s' and therefor was not deleted", TEMP_DIR_PREFIX
             )
 
     def run(self, server_url: str | None = None) -> tuple:
@@ -101,7 +101,7 @@ def run(self, server_url: str | None = None) -> tuple:
                 for metric in metrics:
                     scores[metric] = instance[metric][0]
                 instance_scores[i] = scores
-        except Exception as e:
+        except KeyError as e:
             logger.error("Error in extracting single instance scores")
             logger.error(e)
             logger.error(e.__traceback__)
@@ -112,15 +112,15 @@ def run(self, server_url: str | None = None) -> tuple:
 
 def create_unitxt_yaml(yaml_file, unitxt_recipe, task_name):
     data = {"task": f"{task_name}", "include": "unitxt", "recipe": f"{unitxt_recipe}"}
-    with open(yaml_file, "w") as file:
+    with open(yaml_file, "w", encoding="utf-8") as file:
         yaml.dump(data, file, default_flow_style=False)
-    logger.debug(f"task {task} unitxt recipe written to {yaml_file}")
+    logger.debug("task %s unitxt recipe written to %s",task_name,yaml_file)
 
 
 def create_unitxt_pointer(tasks_dir):
     class_line = "class: !function " + task.__file__.replace("task.py", "task.Unitxt")
     output_file = os.path.join(tasks_dir, "unitxt")
     os.makedirs(os.path.dirname(output_file), exist_ok=True)
-    with open(output_file, "w") as f:
+    with open(output_file, "w", encoding="utf-8") as f:
         f.write(class_line)
-    logger.debug(f"Unitxt task pointer written to {output_file}")
+    logger.debug("Unitxt task pointer written to %s", output_file)