Skip to content

Commit 5631de5

Browse files
Gavin Shantorvalds
Gavin Shan
authored andcommitted
mm/page_reporting: fix code style in __page_reporting_request()
Patch series "mm/page_reporting: Make page reporting work on arm64 with 64KB page size", v4. The page reporting threshold is currently equal to @pageblock_order, which is 13 and 512MB on arm64 with 64KB base page size selected. The page reporting won't be triggered if the freeing page can't come up with a free area like that huge. The condition is hard to be met, especially when the system memory becomes fragmented. This series intends to solve the issue by having page reporting threshold as 5 (2MB) on arm64 with 64KB base page size. The patches are organized as: PATCH[1/4] Fix some coding style in __page_reporting_request(). PATCH[2/4] Represents page reporting order with variable so that it can be exported as module parameter. PATCH[3/4] Allows the device driver (e.g. virtio_balloon) to specify the page reporting order when the device info is registered. PATCH[4/4] Specifies the page reporting order to 5, corresponding to 2MB in size on ARM64 when 64KB base page size is used. This patch (of 4): The lines of comments would be starting with one, instead two space. This corrects the style. Link: https://lkml.kernel.org/r/[email protected] Link: https://lkml.kernel.org/r/[email protected] Signed-off-by: Gavin Shan <[email protected]> Reviewed-by: Alexander Duyck <[email protected]> Cc: David Hildenbrand <[email protected]> Cc: "Michael S. Tsirkin" <[email protected]> Cc: Anshuman Khandual <[email protected]> Cc: Catalin Marinas <[email protected]> Cc: Will Deacon <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
1 parent 832b507 commit 5631de5

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

mm/page_reporting.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ __page_reporting_request(struct page_reporting_dev_info *prdev)
3131
return;
3232

3333
/*
34-
* If reporting is already active there is nothing we need to do.
35-
* Test against 0 as that represents PAGE_REPORTING_IDLE.
34+
* If reporting is already active there is nothing we need to do.
35+
* Test against 0 as that represents PAGE_REPORTING_IDLE.
3636
*/
3737
state = atomic_xchg(&prdev->state, PAGE_REPORTING_REQUESTED);
3838
if (state != PAGE_REPORTING_IDLE)

0 commit comments

Comments
 (0)