Skip to content

Commit cc6266f

Browse files
ChristianKoenigAMDtorvalds
authored andcommitted
mm/dmapool.c: revert "make dma pool to use kmalloc_node"
This reverts commit 2618c60 ("dma: make dma pool to use kmalloc_node"). While working myself into the dmapool code I've found this little odd kmalloc_node(). What basically happens here is that we allocate the housekeeping structure on the numa node where the device is attached to. Since the device is never doing DMA to or from that memory this doesn't seem to make sense at all. So while this doesn't seem to cause much harm it's probably cleaner to revert the change for consistency. Link: https://lkml.kernel.org/r/[email protected] Signed-off-by: Christian König <[email protected]> Cc: Yinghai Lu <[email protected]> Cc: Andi Kleen <[email protected]> Cc: Christoph Lameter <[email protected]> Cc: David Rientjes <[email protected]> Cc: Greg KH <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
1 parent d08d2b6 commit cc6266f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

mm/dmapool.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ struct dma_pool *dma_pool_create(const char *name, struct device *dev,
152152
else if ((boundary < size) || (boundary & (boundary - 1)))
153153
return NULL;
154154

155-
retval = kmalloc_node(sizeof(*retval), GFP_KERNEL, dev_to_node(dev));
155+
retval = kmalloc(sizeof(*retval), GFP_KERNEL);
156156
if (!retval)
157157
return retval;
158158

0 commit comments

Comments
 (0)